Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57868

Incorrect query in feedback_get_incomplete_users for multiple submissions feedbacks

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.4, 3.2.1, 3.3
    • Fix Version/s: 3.1.5, 3.2.2
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a non-anonymous feedback activity with multiple submissions enabled
      2. Submit the feedback a couple of times using the same student account
      3. As admin go to the Show non-respondents tab in the feedback
      4. Check that you see correctly the list of users who didn't respond the feedback
      Show
      Create a non-anonymous feedback activity with multiple submissions enabled Submit the feedback a couple of times using the same student account As admin go to the Show non-respondents tab in the feedback Check that you see correctly the list of users who didn't respond the feedback
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57868-master

      Description

      If you go to the Show non-respondents tab as admin in a feedback module with multiple submissions enabled (and multiple submissions by the same user done) you sill see this error:

      Did you remember to make the first column something unique in your call to get_records? Duplicate value '138' found in column 'userid'.

      line 1103 of /lib/dml/mysqli_native_moodle_database.php: call to debugging()
      line 1380 of /lib/dml/moodle_database.php: call to mysqli_native_moodle_database->get_records_sql()
      line 1331 of /lib/dml/moodle_database.php: call to moodle_database->get_records_select()
      line 1420 of /lib/dml/moodle_database.php: call to moodle_database->get_records()
      line 1003 of /mod/feedback/lib.php: call to moodle_database->get_records_menu()
      line 219 of /mod/feedback/show_nonrespondents.php: call to feedback_get_incomplete_users()

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Mar/17