Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57957

In assignment without grade, feedback files are not shown to students

    Details

    • Testing Instructions:
      Hide

      Prerequisites: a student (S), a teacher (T), an empty course (C) where both are enrolled

      • Log in as T, go to C, and create an assignment. [N.B. must be a *new* assignment, not changing an existing one]. Set the grade scale to "None", submission type to "files" and feedback type to "files" only.
      • Log in as S and submit a file for the assignment.
      • Log in as T and upload a feedback file for the student.
      • Log in as S, and view the assignment page.
      • VERIFY: feedback file is shown below the "submission status" table.
      Show
      Prerequisites: a student (S), a teacher (T), an empty course (C) where both are enrolled Log in as T, go to C, and create an assignment. [N.B. must be a *new* assignment, not changing an existing one] . Set the grade scale to "None", submission type to "files" and feedback type to "files" only. Log in as S and submit a file for the assignment. Log in as T and upload a feedback file for the student. Log in as S, and view the assignment page. VERIFY: feedback file is shown below the "submission status" table.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull 3.2 Branch:
    • Pull Master Branch:

      Description

      This bug occurs when an assignment does not have a grade scale (grade set to "None" in the assignment settings) and teachers upload their feedback files to the students.

      In this situation, students cannot see the feedback files that the teacher has uploaded.

      To reproduce:

      • Create an assignment [N.B. must be a *new* assignment, not changing an existing one], set the grade scale to "None", submission type to "files" and feedback type to "files" only.
      • Log in as a student and submit a file for the assignment.
      • Log in as a teacher and upload a feedback file for the student.
      • Log in as the same student again, and view the assignment page.
      • EXPECTED: feedback file is shown below the "submission status" table.
      • ACTUAL: feedback file is not shown. (The entire "Feedback" section is missing.)

      Related code: mod/assign/locallib.php, method assign::get_assign_feedback_status_renderable, near line 4494: The variable $gradebookgrade is null in the situation above, hence the test in line 4518 fails.

      Workaround: First create the assignment with a grade scale (e.g. points out of 100), save the settings, then edit the settings again to set the grade scale to "None".

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                6 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Jul/17