[MDL-58000] Larger badge images need to be used - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.9.9, 3.0.6, 3.0.7, 3.0.8, 3.1.2, 3.1.3, 3.1.4, 3.2, 3.2.1, 3.3, 3.5
Fix Version/s: 3.6
Component/s: Badges
Labels:
- ci
- patch
- release_notes
- triaged

Affected Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_36_STABLE
Pull from Repository:
https://github.com/mackensen/moodle
Pull Master Branch:
~~MDL-58000~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...mackensen:MDL-58000-master
Testing Instructions:
Hide

You will need a course with some enrolled users.

Enable badges @ Admin -> Advanced features.

Enable course badges @ Admin -> Badges -> Badges settings.

Create a badge. Ensure that the badge image resolution is at least 512x512.

Issue the badge to one or more recipients.

Log in as the recipient and download the badge. It should be 512x512 pixels.
Show
You will need a course with some enrolled users. Enable badges @ Admin -> Advanced features. Enable course badges @ Admin -> Badges -> Badges settings. Create a badge. Ensure that the badge image resolution is at least 512x512. Issue the badge to one or more recipients. Log in as the recipient and download the badge. It should be 512x512 pixels.

Description

Uploaded badge images are processed and stored in three sizes named f1, f2 and f3. However, only the two smallest images are ever used, and they are tiny.

One of the instances this is most apparent is when a badge is baked and the user downloads or syncs it, and the resulting badge image they get is low quality and pixelated. This gives users a very poor experience with badges.

This can be fixed by simply allowing the larger badge image (f3) to be accessible and used. Specifically, a single character change to the bake function in badgeslib.php:1054 to change f1 to f3 on that line would allow larger, high-quality images to be baked and downloaded.

Also see ~~MDL-57569~~ for related issue with filelib.php.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-58000.PNG
62 kB
03/Oct/18 9:49 AM

Issue Links

has a non-specific relationship to

MDL-57569 Large badge images stored but inaccessible

Closed

is duplicated by

MDL-63961 Improve resolution of badge image sent to external backpacks and used when duplicating badges

Closed

Testing discovered

MDL-63487 "◀ Award badge" and "Revoke badge ▶" buttons not styled

Closed

Activity

People

Assignee:: Charles Fulton

Reporter:: Marek Bell

Peer reviewer:: Luca Bösch

Integrator:: Eloy Lafuente (stronk7)

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, Charles Fulton, CiBoT, Eloy Lafuente (stronk7), Luca Bösch, Marek Bell, Marina Glancy, Sara Arjona (@sarjona)

Component watchers:: Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 7 Vote for this issue

Watchers:: 11 Start watching this issue

Dates

Created:: 18/Feb/17 2:49 AM

Updated:: 29/Nov/18 2:44 PM

Resolved:: 05/Oct/18 11:22 AM

Fix Release Date:: 3/Dec/18

Time Tracking

Estimated:

Remaining:

Logged:

30m