Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58021

Regression in Moodle 3.2.1 caused by Boost theme in MDL-56161

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.2.1, 3.3, 3.4
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Install the H5P plugin
      2. Remove HACK from the plugin as decribed in Description (2) below.
      3. Create a course
      4. Add an h5p activity
      5. In the editor part of the form click the “select content type” dropdown and select upload
      6. Upload the test video from here (I’ve also attached it to this issue)
      7. With Editing enabled try editing the content.
      8. TEST to see if the editor window is NOT narrow but full width as it is in Clean theme.
      Show
      Install the H5P plugin Remove HACK from the plugin as decribed in Description (2) below. Create a course Add an h5p activity In the editor part of the form click the “select content type” dropdown and select upload Upload the test video from here (I’ve also attached it to this issue) With Editing enabled try editing the content. TEST to see if the editor window is NOT narrow but full width as it is in Clean theme.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-58021_master

      Description

      The mustache tameplate for form_static in Boost theme causes the editing form-control-static to render as a small area rather than taking up all the space available.
      This was brought to light is the themes forum HERE

      I've tested Boost after removing the class selector from the element-static.mustache template, and found it displays correctly now.

      I have read that there is an issue with 'form-control-static' in that it does not take any notice of sm, md, and lg class selectors which may account for this problem?

      To replicate:

      1. Install the H5P Plugin\
      2. Revert the work around they’ve added in the plugin for boost. In mod_form.php change

                if ($CFG->theme == 'boost') {
                  $h5peditor = array();
                  $h5peditor[] = $mform->createElement('html', '<div class="h5p-editor">' . get_string('javascriptloading', 'hvp') .  '</div>');
                  $mform->addGroup($h5peditor, 'h5peditorgroup', get_string('editor', 'hvp'));
                }
                else {
                  $mform->addElement('static', 'h5peditor', get_string('editor', 'hvp'), '<div class="h5p-editor">' . get_string('javascriptloading', 'hvp') .  '</div>');
                }


        to

        $mform->addElement('static', 'h5peditor', get_string('editor', 'hvp'), '<div class="h5p-editor">' . get_string('javascriptloading', 'hvp') .  '</div>’);

      3. Create a course
      4. Add a h5p activity
      5. In the editor part of the form click the “select content type” dropdown and select upload
      6. Upload the test video from here (I’ve also attached it to this issue)
      7. The editor window will be narrow on boost but full width on clean

        Attachments

        1. before_after.png
          before_after.png
          69 kB
        2. screen_shot_1.png
          screen_shot_1.png
          408 kB
        3. test-1264-28265.h5p
          1.38 MB

          Issue Links

            Activity

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated: