Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58023

behat - find_node_in_navigation performs poorly when expanding many branches

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This affects behat tests only.

      Run the following tests and make sure they pass:

      admin/tests/behat/display_short_names.feature
      admin/tests/behat/filter_users.feature
      admin/roles/tests/behat/override_roles_highlighting.feature
      admin/tool/behat/tests/behat/data_generators.feature

      Show
      This affects behat tests only. Run the following tests and make sure they pass: admin/tests/behat/display_short_names.feature admin/tests/behat/filter_users.feature admin/roles/tests/behat/override_roles_highlighting.feature admin/tool/behat/tests/behat/data_generators.feature
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58023_behat_find_node_in_navigation_improvement_master

      Description

      When in javascript mode, find_node_in_navigation is not efficient when finding a node which is nested deeply in the tree :

      This comment in the code explains the inefficiency:

                          // If node is a link then some driver click in the middle of the node, which click on link and
                          // page gets redirected. To ensure expansion works in all cases, check if the node to expand is a
                          // link and if yes then click on link and wait for it to navigate to next page with node expanded.
      

      This basically means if you have the following node:

      Appearance > Theme > Snap > Features & Benefits

      Then the page has to reload 3 times before the node "Features & Benefits" is revealed.

        Attachments

          Activity

            People

            • Assignee:
              brudinie guy thomas
              Reporter:
              brudinie guy thomas
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Dan Poltawski
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/May/17