[MDL-58032] user_can_view_profile generates notices when $userid = 0 - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.2.1
Fix Version/s: 3.1.5, 3.2.2
Component/s: Libraries, User management
Labels:
- ci
- triaged

Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Master Branch:
~~MDL-58032~~-master
Pull Master Diff URL:
https://github.com/ankitagarwal/moodle/compare/7a3b115d37...MDL-58032-master
Testing Instructions:
1. Run unit tests
2. (optional) comment out the changes in user_can_view_profile() and unittest will fail with a notice.

Sprint:
3.3 on-sync, 3.3 sprint 4

Description

As reported by Dan on MDL-56526

user_can_view_profile() can generate notices when $userid = 0. This happens because $sharedcourses becomes false.

Attachments

Issue Links

caused a regression

MDL-58161 user: tests: user_can_view_profile fails under certain cases

Closed

Activity

People

Assignee:: Ankit Agarwal

Reporter:: Ankit Agarwal

Peer reviewer:: Simey Lameze

Integrator:: Andrew Lyons

Tester:: CiBoT

Participants:: Andrew Lyons, Ankit Agarwal, CiBoT, David Monllaó, Rajesh Taneja, Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 21/Feb/17 9:44 PM

Updated:: 06/Mar/17 7:35 PM

Resolved:: 04/Mar/17 2:41 AM

Fix Release Date:: 13/Mar/17