Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58035

If a particular theme cannot be initialised, it just silently falls back to Boost. It should at least log

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Ensure 'Allow course themes' option is on.
      2. Ensure developer debugging is on.
      3. View a page in the default theme, and verify no debugging is output.
      4. Install a theme based on the old base theme, but don't re-install base.
      5. Create a course set to use the old theme.
      6. Verify that you do get debugging to explain why your course still looks like it is using Boost.

      (Note, if you trust me, you could just pass this. The OU themes broke when we upgraded, and I tested this then.)

      Show
      Ensure 'Allow course themes' option is on. Ensure developer debugging is on. View a page in the default theme, and verify no debugging is output. Install a theme based on the old base theme, but don't re-install base. Create a course set to use the old theme. Verify that you do get debugging to explain why your course still looks like it is using Boost. (Note, if you trust me, you could just pass this. The OU themes broke when we upgraded, and I tested this then.)
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      1. Upgrade your site, using an old theme based on 'base', to Moodle 3.2
      2. Run the unit tests.
      3. Get confused by the following unit test failure:

      coding_exception: Coding error detected, it must be fixed by a programmer: Trying to reference an unknown block region side-post

      What happens is: since base theme has gone, the theme being used in the test cannot be initialised. Therefore it just uses boost (different block regions) with no debug output. It should log an error.

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            cameron1729
            Integrator:
            Dan Poltawski
            Tester:
            Marcus Green
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Mar/17