[MDL-58050] Messaging API - active database transaction detected during request shutdown - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

This affects 3.2 sites only (with the new messaging system)

Install a very fresh site

Watch the site's error log

Log in as any user and visit the main messaging page (/message/index.php). There must be no conversations (thence a fresh installation).

TEST: Make sure the reported error is not displayed in the error log

REGTEST: Make sure the messaging between users works as expected

p.s. You should first check that you can reproduce the issue to make sure your error_log is configured in a way allowing you to test the lack of the error.
Show
This affects 3.2 sites only (with the new messaging system) Install a very fresh site Watch the site's error log Log in as any user and visit the main messaging page (/message/index.php). There must be no conversations (thence a fresh installation). TEST: Make sure the reported error is not displayed in the error log REGTEST: Make sure the messaging between users works as expected p.s. You should first check that you can reproduce the issue to make sure your error_log is configured in a way allowing you to test the lack of the error.
Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
git://github.com/mudrd8mz/moodle.git
Pull Master Branch:
~~MDL-58050~~-master-msgtrans
Pull Master Diff URL:
https://github.com/mudrd8mz/moodle/compare/9ec952f237...MDL-58050-master-msgtrans

While testing ~~MDL-56679~~ I spotted the following errors in my error_log:

[Wed Feb 22 11:43:28.627568 2017] [:error] [pid 29269] [client ::1:52378] Potential coding error - active database transaction detected during

request shutdown:\n* line 302 of /message/classes/api.php: call to moodle_database->start_delegated_transaction()\n* line 108 of /message/index

.php: call to core_message\\api::get_conversations()\n, referer: http://glux/mdk/i33/my/

The method get_conversations() starts delegated transaction but in certain circumstances it exits early before committing it.

Discovered while testing

MDL-56679 lib/classes/notification.php default object from empty value PHP warning

Participants:: CiBoT, Dan Poltawski, David Mudrák (@mudrd8mz), John Okely, Mark Nelson

Component watchers:: Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)