Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58055

Forum go to first unread post / mark thread read usability regression

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.5, 3.2.1, 3.3
    • Fix Version/s: 3.1.6, 3.2.3
    • Component/s: Forum, Usability
    • Labels:
    • Testing Instructions:
      Hide

      In clean theme:

      1. As admin, create a course, enrol a student, add a forum, make a post.
      2. As student, ensure unread forum post tracking is on.
      3. Go to the forum, on the page where it lists the discussions
        1. Confirm that there is no padding on the "Mark all as read" link on the side of the link to view
      Show
      In clean theme: As admin, create a course, enrol a student, add a forum, make a post. As student, ensure unread forum post tracking is on. Go to the forum, on the page where it lists the discussions Confirm that there is no padding on the "Mark all as read" link on the side of the link to view
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58055-master
    • Pull Master Diff URL:

      Description

      Ages ago, I implemented MDL-32359, which was a small, but quite important usability win.

      Then tonight, many time on Moodle.org, I found that I had marked a forum thread read, when I was trying to click the link to go to the first unread post.

      I think this was broken by MDL-57093, which did not in itself introduce the stupid padding: 0 rule that is to blame. That came from MDL-42711. The problem with MDL-57093 is that it changed the selectors to be less specific, so the wrong style rule in MDL-42711 suddenly took effect.

      Anyway, there is now an annoying usability bug. Please can someone fix it.

        Attachments

          Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57093 Notifications drop down on boost looks poor on forum pages

          • Major - Major loss of function, incorrect output
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-42711 Bootstrap base: import visual fixes from learnmoodle

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              timhunt Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Barbara Ramiro, Bas Brands
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/May/17