XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5
Fix Version/s: 3.5
Component/s: Media
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_35_STABLE
Fixed Branches:
MOODLE_35_STABLE
Pull from Repository:
https://github.com/lucisgit/moodle.git
Pull Main Branch:
~~MDL-58065~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...lucisgit:MDL-58065-master
Testing Instructions:
Hide

Steps for testing:

Open media_videojs settings and enable both flash and RTMP.

Add page to the course and in the editor insert the URL link pointing to rtmp://184.72.239.149/vod/&mp4:BigBuckBunny_115k.mov (example stream URL is taken from https://www.hdwplayer.com/rtmp-player/)

Save and view the page in the browser. It might be that you will see the error "No compatible source was found for this media.", in this case set Flash setting to "Allow" in your browser (rather than "ask"). This browser behaviour is not specific to this patch, any flash content seem require explicit permissions in Chrome at least on my PC.

The unit test is provided as well.
Show
Steps for testing: Open media_videojs settings and enable both flash and RTMP. Add page to the course and in the editor insert the URL link pointing to rtmp://184.72.239.149/vod/&mp4:BigBuckBunny_115k.mov (example stream URL is taken from https://www.hdwplayer.com/rtmp-player/ ) Save and view the page in the browser. It might be that you will see the error "No compatible source was found for this media.", in this case set Flash setting to "Allow" in your browser (rather than "ask"). This browser behaviour is not specific to this patch, any flash content seem require explicit permissions in Chrome at least on my PC. The unit test is provided as well.

Description

Full Steps

Go into a course
Turn editing on
Add HTML5 video source code or RTMP video link (from repository or just as link/video link)
Save

What I Expected

Core multimedia filter should configure VideoJS player to wrap HTML5 video source code for RTMP src

What Actually Happens

VideoJS player reports that media could not be loaded, either because the server or network failed or because the format is not supported. The core multimedia filter in the media/classes/manager.php file, get_mimetype() function does not account for the initial rtmp:// in the video src URL. It only looks at the filetype .mp4 and returns type="video/mp4". VideoJS will work with RTMP, but the type needs to be specified as "rtmp/mp4".

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Screenshot (2).png
52 kB
15/Jun/17 8:01 AM
Verified_MDL-58065.png
258 kB
13/Apr/18 1:21 AM

Issue Links

has a QA test

MDLQA-12273 VideoJS player can be configured for RTMP

Open

MDLQA-15944 CLONE - VideoJS player can be configured for RTMP

Open

MDLQA-15355 CLONE - VideoJS player can be configured for RTMP

Passed

has been marked as being related by

MDL-72407 The VideoJS Flash plugin should be removed from core

Closed

is blocked by

MDL-59274 Upgrade Video.JS to 6.3.2 and videojs_youtube to 2.4.0

Closed

MDL-59255 core_media_manager::split_alternatives is not RTMP friendly

Closed

(1 is blocked by)

Activity

People

Assignee:: Ruslan Kabalin

Reporter:: Michelle Melton

Peer reviewer:: Tim Hunt

Integrator:: Andrew Lyons

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, Eloy Lafuente (stronk7), Helen Foster, Marina Glancy, Mark Nelson, Mary Cooch, Michelle Melton, Nadav Kavalerchik, Ruslan Kabalin, Tim Hunt

Votes:: 3 Vote for this issue

Watchers:: 9 Start watching this issue

Dates

Created:: 24/Feb/17 12:40 PM

Updated:: 24/Aug/21 10:21 PM

Resolved:: 13/Apr/18 7:29 AM

Fix Release Date:: 17/May/18

Time Tracking

Estimated:

Remaining:

Logged: