Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58072

tabtree.mustache not enclosing "title" attribute in quotes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to the system administration page to manage roles (e.g. http://[yoursite]/admin/roles/manage.php).
      2. View the HTML page source for the page.
      3. Find the "tabs" area for the page (for example, the "Manage roles" tab).
      4. Note that the HTML looks like this:
        Before fix:
        <li class="nav-item">
        <a class="nav-link active " title=Manage roles>Manage roles</a>
        </li>
        After fix:
        <li class="nav-item">
        <a class="nav-link active" title="Manage roles">Manage roles</a>
        </li>
      Show
      Go to the system administration page to manage roles (e.g. http://[yoursite]/admin/roles/manage.php ). View the HTML page source for the page. Find the "tabs" area for the page (for example, the "Manage roles" tab). Note that the HTML looks like this: Before fix: <li class="nav-item"> <a class="nav-link active " title=Manage roles>Manage roles</a> </li> After fix: <li class="nav-item"> <a class="nav-link active" title="Manage roles">Manage roles</a> </li>
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-58072_master_tabtree_mustache

      Description

      In the tabtree.mustache file of the Boost theme, a link is created with a "title" attribute, but the value of the attribute is not enclosed in quotes as required by proper HTML.

        Attachments

          Activity

            People

            Assignee:
            mchurch Mike Churchward
            Reporter:
            mchurch Mike Churchward
            Peer reviewer:
            Jake Dallimore
            Integrator:
            Andrew Nicols
            Tester:
            Andrew Nicols
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Mar/17