Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.2.2
Affects Version/s: 3.2
Component/s: Themes
Labels:
- boost
- ci
- triaged

Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
https://github.com/mchurchward/moodle/
Pull Main Branch:
~~MDL-58072~~_master_tabtree_mustache
Pull Main Diff URL:
https://github.com/mchurchward/moodle/commit/85d9ed8b3b0f4b1004b897f4f9e5b93e3a6a2fab
Testing Instructions:
Hide

Go to the system administration page to manage roles (e.g. http://[yoursite]/admin/roles/manage.php).

View the HTML page source for the page.

Find the "tabs" area for the page (for example, the "Manage roles" tab).

Note that the HTML looks like this:
Before fix:
<li class="nav-item">
<a class="nav-link active " title=Manage roles>Manage roles</a>
</li>
After fix:
<li class="nav-item">
<a class="nav-link active" title="Manage roles">Manage roles</a>
</li>
Show
Go to the system administration page to manage roles (e.g. http://[yoursite]/admin/roles/manage.php ). View the HTML page source for the page. Find the "tabs" area for the page (for example, the "Manage roles" tab). Note that the HTML looks like this: Before fix: <li class="nav-item"> <a class="nav-link active " title=Manage roles>Manage roles</a> </li> After fix: <li class="nav-item"> <a class="nav-link active" title="Manage roles">Manage roles</a> </li>

In the tabtree.mustache file of the Boost theme, a link is created with a "title" attribute, but the value of the attribute is not enclosed in quotes as required by proper HTML.

Assignee:: Mike Churchward

Reporter:: Mike Churchward

Peer reviewer:: Jake Dallimore

Integrator:: Andrew Lyons

Tester:: Andrew Lyons

Participants:: Andrew Lyons, CiBoT, Jake Dallimore, Mike Churchward

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 25/Feb/17 7:20 AM

Updated:: 14/Mar/17 5:46 AM

Resolved:: 04/Mar/17 2:40 AM

Details

Description

Attachments

Activity

People

Dates

Clockify