Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58116

Emails are being sent by noreply emailaddress even if it shoud not.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2, 3.2.1
    • Fix Version/s: 3.1.6, 3.2.3
    • Component/s: Enrolments
    • Labels:
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      Make sure you have a email setup on your moodle instance, you can use MailCatcher or a docker instance.

      • Enrol a teacher in a course with manual enrolment.
      • Enrol a student in a course with another enrolment method (e.g. with global groups).
      • In the course, as teacher, set up a forum with auto subscription.
      • As teacher, post a message in the forum.
      • As student make sure you got the forum post via email and that it was sent via email address of the teacher (not the noreply address).
      Show
      Make sure you have a email setup on your moodle instance, you can use MailCatcher or a docker instance. Enrol a teacher in a course with manual enrolment. Enrol a student in a course with another enrolment method (e.g. with global groups). In the course, as teacher, set up a forum with auto subscription. As teacher, post a message in the forum. As student make sure you got the forum post via email and that it was sent via email address of the teacher (not the noreply address).
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-58116-master

      Description

      Emails are being sent by moodle with the noreply emailaddress instead of the user emailaddress.
      The cause is that the users are not enroled with the same enrolment method.

      Prereqs:
      The teacher have got an emailadress with an allowed domain to send emails from.
      The teacher and the student are not together in a course.
      The student set up the notification preferences to get subscribed forum posts via email on- and offline.

      Test steps:
      1. Enrol a teacher in a course with manual enrolment
      2. Enrol a student in a course with another enrolemnt mehtod may be with global groups
      3. In the course, the teacher set up a forum with auto subscription
      4. The teacher is posting a message in the forum.
      5. The student will get the forum post via email and recognize that the post was sent via noreply address instead of the emailaddress of the teacher.

      Cause:
      The function call of enrol_get_shared_courses in the function can_send_from_real_email_address returns only "true" if the users are enrolled by the same enrolment method.

        Attachments

          Activity

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/May/17