Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58119

Use Cache-Control: immutable (backport of MDL-57789)

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      (difficulty: easy, requires teacher access to a course of two Moodle properly configured instances, one being fully HTTPS)

      1. When browsing the instance both as guest and as teacher each Moodle page should be correctly styled and no image should be missing
      2. Components serving files like SCORM or a File System repository should be attended and navigated up to their contents w/o any issue (regressions)
      3. When using the Moodle instance under HTTPS with Firefox, latest update (49+), if you open the Developer Tools (F12) and look at the network tab while htting F5 (Refresh) you should find no HTTP 304 hits to any of the theme related files (CSS, JS, GIF/PNG/SVG) i.e. only HTTP 200 w/ a clear indication about the content being cached. HTTP 304s could appear when browsing some components like a SCORM activity when attended it the n-th time (where n > 1) or some other blocks.
      4. More on regressions: repeat the test in MDL-39832, if you want to be sure that partial content serving is still working
      Show
      (difficulty: easy, requires teacher access to a course of two Moodle properly configured instances, one being fully HTTPS) When browsing the instance both as guest and as teacher each Moodle page should be correctly styled and no image should be missing Components serving files like SCORM or a File System repository should be attended and navigated up to their contents w/o any issue (regressions) When using the Moodle instance under HTTPS with Firefox, latest update (49+), if you open the Developer Tools (F12) and look at the network tab while htting F5 (Refresh) you should find no HTTP 304 hits to any of the theme related files (CSS, JS, GIF/PNG/SVG) i.e. only HTTP 200 w/ a clear indication about the content being cached . HTTP 304s could appear when browsing some components like a SCORM activity when attended it the n-th time (where n > 1) or some other blocks. More on regressions: repeat the test in MDL-39832 , if you want to be sure that partial content serving is still working
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:

      Description

      This looks to be a really nice performance win with a relatively small impact. Would be really good if this could be backported to stable branches - makes Moodle look good with fast loading times, and decreases overall load on servers.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Sep/17