Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58121

$supportuser not defined before use in email_to_user function

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This can only be tested with unit tests, as we don't use the $attachment and $attachname params in core.

      1. Comment out the change to lib/moodlelib.php introduced with this patch.
      2. Run the moodlelib_test.php unit tests.
      3. Confirm that the test_email_to_user test fails.
      4. Uncomment the line from step 1.
      5. Run the moodlelib_test.php unit tests.
      6. Confirm that the test_email_to_user test passes.
      Show
      This can only be tested with unit tests, as we don't use the $attachment and $attachname params in core. Comment out the change to lib/moodlelib.php introduced with this patch. Run the moodlelib_test.php unit tests. Confirm that the test_email_to_user test fails. Uncomment the line from step 1. Run the moodlelib_test.php unit tests. Confirm that the test_email_to_user test passes.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58121-master

      Description

      It's used here but is never defined beforehand.

        Attachments

          Activity

            People

            Assignee:
            jaked Jake Dallimore
            Reporter:
            jaked Jake Dallimore
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Dan Poltawski
            Tester:
            CiBoT
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/May/17