[MDL-58121] $supportuser not defined before use in email_to_user function - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

This can only be tested with unit tests, as we don't use the $attachment and $attachname params in core.

Comment out the change to lib/moodlelib.php introduced with this patch.

Run the moodlelib_test.php unit tests.

Confirm that the test_email_to_user test fails.

Uncomment the line from step 1.

Run the moodlelib_test.php unit tests.

Confirm that the test_email_to_user test passes.
Show
This can only be tested with unit tests, as we don't use the $attachment and $attachname params in core. Comment out the change to lib/moodlelib.php introduced with this patch. Run the moodlelib_test.php unit tests. Confirm that the test_email_to_user test fails. Uncomment the line from step 1. Run the moodlelib_test.php unit tests. Confirm that the test_email_to_user test passes.
Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
https://github.com/snake/moodle.git
Pull Master Branch:
~~MDL-58121~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/98c4094eac267...snake:MDL-58121-master

It's used here but is never defined beforehand.

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)