Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58155

Stray end tag in grading_navigation.mustache

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.1.4, 3.2.3
    • Fix Version/s: None
    • Component/s: Assignment
    • Labels:
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE

      Description

      In the Essential theme the grading_navigation.mustache template (from /mod/assign/templates) was copied and slightly changed. Recent changes to the plugins database means that checks are being undertaken, e.g: https://moodle.org/plugins/pluginversion.php?id=13372&smurf=html#mustache with the error "HTML Validation error, line 24: Stray end tag “span”. (v><br/></span></div)".

      This has showed up a stray end tag in grading_navigation.mustache line 77 in the M3.1 version and line 74 in the M3.2 version being around here:

      <br/>
      {{#caneditsettings}}
      <a href="{{config.wwwroot}}/course/modedit.php?update={{cmid}}&return=1">{{#pix}}t/edit, core,{{#str}}editsettings{{/str}}{{/pix}}</a>
      {{/caneditsettings}}
      </span>
      </div>
      

      and here:

      {{#caneditsettings}}
      <a href="{{config.wwwroot}}/course/modedit.php?update={{cmid}}&return=1">{{#pix}}t/edit, core,{{#str}}editsettings{{/str}}{{/pix}}</a>
      {{/caneditsettings}}
      {{#duedate}}
      <small data-region="assignment-tooltip" aria-describedby="tooltip-{{uniqid}}">{{#str}}duedatecolon, mod_assign, {{duedatestr}}{{/str}}</small>
      {{/duedate}}
      </span>
      </div>
      

      for M3.1.

      Inspection of the full grading page (e.g 'https://moodlesite.mine/mod/assign/view.php?id=55&action=grader') reveals no start 'span' tag when the templates are combined.

      Therefore, two things:

      • It needs to be removed.
      • Automated checks need to be updated to catch this sort of thing on core code as well as contributed code.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              gb2048 Gareth J Barnard
              Participants:
              Component watchers:
              Damyon Wiese, Adrian Greeve, Mihail Geshoski, Peter Dias
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: