[MDL-58161] user: tests: user_can_view_profile fails under certain cases - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.1.5, 3.2.1, 3.3, 3.4
Fix Version/s: 3.2.4, 3.3.1
Component/s: Unit tests
Labels:
- ci
- netspot
- partner
- triaged

Affected Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
Fixed Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE
Pull from Repository:
https://github.com/tlock/moodle.git
Pull Main Branch:
mdl58161-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/moodle:master...tlock:mdl58161-master
Difficulty:
Easy
Testing Instructions:

Hide

Run the unit test file: user/tests/userlib_test.php

Show
Run the unit test file: user/tests/userlib_test.php

Description

The unit tests updated in ~~MDL-58032~~ has caused the unit test for 'user_can_view_profile' to fail because of assumptions that would be unique role archetype in the database.

Most cases this is true but if you have default additional roles to be tested again would cause this to fail. The code needs to be adjusted to account for this.

Attachments

Issue Links

is a regression caused by

MDL-58032 user_can_view_profile generates notices when $userid = 0

Closed

Activity

People

Assignee:: Tim Lock

Reporter:: Tim Lock

Peer reviewer:: Damyon Wiese

Integrator:: Eloy Lafuente (stronk7)

Tester:: CiBoT

Participants:: CiBoT, Damyon Wiese, Eloy Lafuente (stronk7), Jake Dallimore, Juan Leyva, Marina Glancy, Tim Lock

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 06/Mar/17 7:14 PM

Updated:: 17/Jun/17 12:01 AM

Resolved:: 17/Jun/17 12:01 AM

Fix Release Date:: 10/Jul/17