Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.2, 3.4, 3.4.1
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_32_STABLE, MOODLE_34_STABLE
-
Fixed Branches:MOODLE_33_STABLE, MOODLE_34_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-58179-master-fix -
Pull Master Diff URL:
Description
The Lesson mod has some old code that uses the CSS class .label, which clashes with the Bootstrap class of .label. This makes the span look odd in Bootstrap based themes like Clean and Boost.
As far as I can tell, these classnames (.label and .labelcorrect) have no Lesson specific styles associated with them, so possibly just deleting them from the code is okay. Two examples:
pagetypes/shortanswer.php
|
202: $cells[] = '<span class="labelcorrect">'.get_string("answer", "lesson")." $i</span>: \n"; |
204: $cells[] = '<span class="label">'.get_string("answer", "lesson")." $i</span>: \n"; |
209: $cells[] = '<span class="labelcorrect">'.get_string("answer", "lesson")." $i</span>: \n"; |
You can see this by going into a Lesson with at least one page in it and going into the tab Edit and sub-tab Expanded.
Removing the ":" may also make things look a bit nicer, since the text is right-aligned anyway