[MDL-58182] Course drag and drop dialogue missing buttons - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.1.5, 3.2.2
Fix Version/s: 3.1.6, 3.2.3
Component/s: JavaScript
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Pull from Repository:
https://github.com/snake/moodle.git
Pull Master Branch:
~~MDL-58182~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/98c4094eac2...snake:MDL-58182-master
Testing Instructions:
Hide

Please perform all tests from ~~MDL-56364~~

In addition:

Drag and drop a png from your local filesystem into the course page.

Confirm that the dialog box has the 'Upload' and 'Cancel' buttons

Select the option to create a new file resource and click 'Upload'

Now, edit the file resource that was just created

Click the file in the file manager

In the dialogue, click 'Delete'

Confirm that you see the confirmation dialogue with 'Ok' and 'Cancel' buttons.
Show
Please perform all tests from MDL-56364 In addition: Drag and drop a png from your local filesystem into the course page. Confirm that the dialog box has the 'Upload' and 'Cancel' buttons Select the option to create a new file resource and click 'Upload' Now, edit the file resource that was just created Click the file in the file manager In the dialogue, click 'Delete' Confirm that you see the confirmation dialogue with 'Ok' and 'Cancel' buttons.

Description

Regression introduced by my changes in ~~MDL-56364~~. Should be a relatively easy fix for this one.

By moving the buttons to the modifyAttr call, and making them readOnly, I've effectively blocked the setter. I'll come up with an alternative solution here.

Attachments

Issue Links

has been marked as being related by

MDL-39913 File type restrictions for Assignment submissions

Closed

is a regression caused by

MDL-56364 Assignment grading: Changing annotation colour erroneously changes selected annotation tool

Closed

is duplicated by

MDL-58270 Drop and drop dialogue has lost its buttons

Closed

MDL-58417 Drag and drop onto course page dialogue missing buttons

Closed

MDL-58293 No Upload or Cancel button displayed when dragging SCORM onto course page

Closed

MDL-58304 Unable to drag and drop picture in course

Closed

MDL-58554 Add image to course page doesn't work

Closed

MDL-58753 Boost: No ok button by drag and drop for links and images

Closed

(3 is duplicated by)

Activity

People

Assignee:: Jake Dallimore

Reporter:: Jake Dallimore

Peer reviewer:: Eric Merrill

Integrator:: David Monllaó

Tester:: Marcus Green

Participants:: CiBoT, Dan Poltawski, David Monllaó, Eric Merrill, Gus Hagelberg, Jake Dallimore, Luca Bösch, Marcus Green

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 7 Vote for this issue

Watchers:: 21 Start watching this issue

Dates

Created:: 08/Mar/17 4:53 PM

Updated:: 29/Apr/17 4:33 AM

Resolved:: 24/Mar/17 1:39 PM

Fix Release Date:: 8/May/17