Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58182

Course drag and drop dialogue missing buttons

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Please perform all tests from MDL-56364

      In addition:

      1. Drag and drop a png from your local filesystem into the course page.
      2. Confirm that the dialog box has the 'Upload' and 'Cancel' buttons
      3. Select the option to create a new file resource and click 'Upload'
      4. Now, edit the file resource that was just created
      5. Click the file in the file manager
      6. In the dialogue, click 'Delete'
      7. Confirm that you see the confirmation dialogue with 'Ok' and 'Cancel' buttons.
      Show
      Please perform all tests from MDL-56364 In addition: Drag and drop a png from your local filesystem into the course page. Confirm that the dialog box has the 'Upload' and 'Cancel' buttons Select the option to create a new file resource and click 'Upload' Now, edit the file resource that was just created Click the file in the file manager In the dialogue, click 'Delete' Confirm that you see the confirmation dialogue with 'Ok' and 'Cancel' buttons.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58182-master

      Description

      Regression introduced by my changes in MDL-56364. Should be a relatively easy fix for this one.

      By moving the buttons to the modifyAttr call, and making them readOnly, I've effectively blocked the setter. I'll come up with an alternative solution here.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                7 Vote for this issue
                Watchers:
                21 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/May/17