Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58192

Improve definitions of the custom completion rules in the standard modules

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 3.3
    • Activity completion
    • MOODLE_33_STABLE

      Something that we should do and recommend for other developers:
      1. checkbox should be converted to advcheckbox to avoid repeated if (empty(...))
      2. validation can be moved into the definition so the function add_completion_rules() from module forms can be easier reused for bulk completion, there are methods in moodleform for it: $this->_form->addRule() and $this->_form->addFormRule()

            Unassigned Unassigned
            marina Marina Glancy
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.