Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58192

Improve definitions of the custom completion rules in the standard modules

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.3
    • Fix Version/s: None
    • Component/s: Activity completion
    • Labels:
    • Affected Branches:
      MOODLE_33_STABLE

      Description

      Something that we should do and recommend for other developers:
      1. checkbox should be converted to advcheckbox to avoid repeated if (empty(...))
      2. validation can be moved into the definition so the function add_completion_rules() from module forms can be easier reused for bulk completion, there are methods in moodleform for it: $this->_form->addRule() and $this->_form->addFormRule()

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                marina Marina Glancy
                Participants:
                Component watchers:
                Sam Marshall, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: