Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58263

Use the new before_standard_html_head callback to print the smartapp banner headers

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.2
    • Fix Version/s: 3.3
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide
      1. You need an iPhone, iPad or iPod for testing this
      2. Enable mobile services (Administration > Mobile app > Mobile settings)
      3. Enable Smart App Banners (Administration > Mobile app > Mobile appearance)
      4. Uninstall the Moodle Mobile app (if it was installed in your device)
      5. Now, open Safari in your mobile device, enter your Moodle site URL and check that a banner promoting the app is displayed with an option view it in the app store
      6. Install the Moodle Mobile app
      7. Close and open again Safari, check the site again, the browser should launch now the app when you click on the banner button for opening the app
      Show
      You need an iPhone, iPad or iPod for testing this Enable mobile services (Administration > Mobile app > Mobile settings) Enable Smart App Banners (Administration > Mobile app > Mobile appearance) Uninstall the Moodle Mobile app (if it was installed in your device) Now, open Safari in your mobile device, enter your Moodle site URL and check that a banner promoting the app is displayed with an option view it in the app store Install the Moodle Mobile app Close and open again Safari, check the site again, the browser should launch now the app when you click on the banner button for opening the app
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58263-master

      Description

      We should use the new callback to avoid having tool_mobile related code in core libs.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jleyva Juan Leyva
                Reporter:
                jleyva Juan Leyva
                Peer reviewer:
                Pau Ferrer
                Integrator:
                Dan Poltawski
                Tester:
                Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/May/17