Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58272

Unoconv dies when converting from images (jpg)

    Details

    • Testing Instructions:
      Hide
      1. As admin, make sure unoconv is the only document converter enabled. [Site admin > Plugins > Document converters > Manage document converters].
      2. Verify unoconv is working by checking the test page on it's settings page (click 'settings' from the manage converters page).
      3. Create a course, enrol a student and a teacher.
      4. Create an assignment allowing file submissions and don't restrict the file types allowed.
      5. As the student submit a jpg file to the assignment with the '.jpg' file extension (not jpe, not jpeg). So that this submission doesn't collide with prior conversion attempts, please make sure to rename any existing jpeg file before uploading it, eg. testfile.jpg to testfile-1.jpg. This will ensure reconversion for this file type.
      6. Now, as the teacher, login and grade the assignment.
      7. Verify you see the converted JPEG and not just an empty page.
      8. Repeat the test for files with extensions .jpeg and .jpe (also under the image/jpeg mimetype) and confirm these fail to convert. The unoconv converter doesn't support these extensions.
      9. Repeat the test using the original, working jpg file, but this time remove the extension before uploading the file. Confirm this fails to convert.
      Show
      As admin, make sure unoconv is the only document converter enabled. [Site admin > Plugins > Document converters > Manage document converters] . Verify unoconv is working by checking the test page on it's settings page (click 'settings' from the manage converters page). Create a course, enrol a student and a teacher. Create an assignment allowing file submissions and don't restrict the file types allowed. As the student submit a jpg file to the assignment with the '.jpg' file extension (not jpe, not jpeg). So that this submission doesn't collide with prior conversion attempts, please make sure to rename any existing jpeg file before uploading it, eg. testfile.jpg to testfile-1.jpg. This will ensure reconversion for this file type. Now, as the teacher, login and grade the assignment. Verify you see the converted JPEG and not just an empty page. Repeat the test for files with extensions .jpeg and .jpe (also under the image/jpeg mimetype) and confirm these fail to convert. The unoconv converter doesn't support these extensions. Repeat the test using the original, working jpg file, but this time remove the extension before uploading the file. Confirm this fails to convert.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull 3.3 Branch:
      MDL-58272-33-2
    • Pull 3.4 Branch:
      MDL-58272-34-2
    • Pull Master Branch:
      MDL-58272-master-2

      Description

      When a student submits an image besides some text document, the system dies when trying to convert the submission for grading, and the scheduled task process for conversion takes lots of cpu resources. We have seen 100% cpu load for a few weeks till now.

      We should handle images separately. Or probably ignore them.

      This really bothers our institution since there is no setting to prevent submitting certain filetypes for the given assignment.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  8 Vote for this issue
                  Watchers:
                  14 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    15/Jan/18