Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58277

mod_assign document services breaks if one document is unsupported

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.3, 3.4
    • Fix Version/s: None
    • Component/s: Assignment
    • Labels:
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE

      Description

      Replication
      1. As a student, upload four documents to an assignment:
        1. DOC
        2. PDF
        3. HTML
        4. Shell script
      Expected

      All valid documents are converted

      Actual

      No documents are converted

      Implementation notes

      This isn't as easy as it looks. The problem comes if a regeneration is forced for a document when the supported document list has changed.
      We don't know the number of pages in that shell script, and if it happens in the middle... well, it means that we have to be clever about shifting existing annotations.
      Annotations are currently against the whole converted document. It is unaware of the constituent parts, of how many pages they have, etc. If we insert a new page in the middle, or remove an existing one, we currently do not move the annotations to keep with the relevant PDF.
      Basically, we'd need to either make the annotations document-aware, or make the document_services API more aware of the annotations and page counts at the point that we convert a document.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: