[MDL-58278] Grade, feedback and rubric data not saved when Marking Workflow state not Released - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.2.2
Fix Version/s: 3.1.6, 3.2.3
Component/s: Assignment
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Main Branch:
~~MDL-58278~~-master
Pull Main Diff URL:
https://github.com/damyon/moodle/compare/1034421264...MDL-58278-master
Testing Instructions:
Hide

Make an assignment with marking workflow enabled

Try and add a grade, but not set the workflow state to released (Leave send notifications checked)

Verify the grade was saved

Try and add a grade, but set the workflow state to released. (Leave send notifications checked)

Verify the grade was saved and notification sent

Verify behat is passing (check with integration team)
Show
Make an assignment with marking workflow enabled Try and add a grade, but not set the workflow state to released (Leave send notifications checked) Verify the grade was saved Try and add a grade, but set the workflow state to released. (Leave send notifications checked) Verify the grade was saved and notification sent Verify behat is passing (check with integration team)

Description

With Marking Workflow enabled on an assignment, entering a grade without changing the workflow state will not save the grade. It appears to save (the overlay says "Saving changes..." at the top of screen), but if you navigate to the next student, then back again, the grade is gone.

I've confirmed in my testing that the grade, feedback and rubric data all disappears.

If you change the workflow state to Released, then everything is saved.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

workflow_bug.mp4
1.51 MB
16/Mar/17 5:47 PM

Issue Links

is a regression caused by

MDL-57222 Marking workflow and grading do not save when Assignment hidden

Closed

Activity

People

Assignee:: Damyon Wiese

Reporter:: Michael Woods

Peer reviewer:: Jake Dallimore

Integrator:: David Monllaó

Tester:: Marcus Green

Participants:: Brett Graham, CiBoT, Damyon Wiese, David Monllaó, Garry Edmonds, Jake Dallimore, Michael Woods

Votes:: 5 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 16/Mar/17 5:41 PM

Updated:: 02/May/17 11:35 PM

Resolved:: 22/Apr/17 7:56 AM

Fix Release Date:: 8/May/17