[MDL-58288] Test PDF link needs fixing - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.3
Fix Version/s: 3.3
Component/s: Assignment, Libraries
Labels:
- ci
- triaged

Affected Branches:
MOODLE_33_STABLE
Fixed Branches:
MOODLE_33_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-58288~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/98c4094eac...MDL-58288-master
Testing Instructions:
1. Navigate to Site admin -> Plugins -> Document converters
2. Enable unoconv and set the path
3. View the Test PDF
  1. Confirm that the file was (eventually) generated

Description

I don't think we should fail this issue - but we need a followup next week.

The test pdf link needs the same refactoring patch as the last one Andrew added during integration.
Exception - Argument 1 passed to fileconverter_unoconv\converter::poll_conversion_status() must be an instance of core_files\conversion, instance of fileconverter_unoconv\converter given, called in [dirroot]/files/converter/unoconv/classes/converter.php on line 211

Attachments

Issue Links

is a regression caused by

MDL-55528 File conversion API should be a plugin interface

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Dan Poltawski

Peer reviewer:: Dan Poltawski

Integrator:: David Monllaó

Tester:: Damyon Wiese

Participants:: Andrew Lyons, CiBoT, Damyon Wiese, Dan Poltawski, David Monllaó

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 17/Mar/17 6:28 AM

Updated:: 24/Mar/17 1:39 PM

Resolved:: 24/Mar/17 1:39 PM

Fix Release Date:: 15/May/17