Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58315

Boost theme ignores HTML block custom classes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2, 3.2 regressions, 3.3
    • Fix Version/s: 3.5.7, 3.6.5
    • Component/s: Themes
    • Testing Instructions:
      Hide

      Prerequisites:
      1 Moodle site
      1 Admin user

      1. Go to Site Administration -> Plugins -> Blocks -> HTML
      2. Enable block_html_allowcssclasses
      3. Press Save changes
      4. Go to Site Administration -> Appearance -> Themes -> Boost
      5. Select Advanced settings
      6. Add the following to Raw SCSS .MDL-58315.test {background: red;}
      7. Go to Site Administration -> Appearance -> Themes -> Classic
      8. Select Advanced settings
      9. Add the following to Raw SCSS .MDL-58315.test {background: green;}
      10. Press Save changes
      11. Purge the site caches to ensure the SCSS changes are reflected in the themes
      12. Navigate back to the Admin users' dashboard
      13. Turn site editing on
      14. Add a HTML block
      15. Using Boost
      16. Verify that the HTML block background IS NOT red
      17. Using Classic
      18. Verify that the HTML block background IS NOT green
      19. Edit the HTML block
      20. In the "Additional CSS classes" text box enter the following: MDL-58315 test
      21. Press Save changes
      22. Using Boost
      23. Verify that the HTML block background IS red
      24. Using Classic
      25. Verify that the HTML block background IS green
      Show
      Prerequisites: 1 Moodle site 1 Admin user Go to Site Administration -> Plugins -> Blocks -> HTML Enable block_html_allowcssclasses Press Save changes Go to Site Administration -> Appearance -> Themes -> Boost Select Advanced settings Add the following to Raw SCSS . MDL-58315 .test {background: red; } Go to Site Administration -> Appearance -> Themes -> Classic Select Advanced settings Add the following to Raw SCSS . MDL-58315 .test {background: green; } Press Save changes Purge the site caches to ensure the SCSS changes are reflected in the themes Navigate back to the Admin users' dashboard Turn site editing on Add a HTML block Using Boost Verify that the HTML block background IS NOT red Using Classic Verify that the HTML block background IS NOT green Edit the HTML block In the "Additional CSS classes" text box enter the following:  MDL-58315 test Press Save changes Using Boost Verify that the HTML block background IS red Using Classic Verify that the HTML block background IS green
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
      MDL-58315_35_boost_block_classes
    • Pull 3.6 Branch:
      MDL-58315_36_boost_block_classes
    • Pull Master Branch:
      MDL-58315_master_boost_block_classes

      Description

      if block_html_allowcssclasses is enabled and extra css tags are entered into an html block settings page, these classes aren't added to the page when the Boost theme is selected.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                8 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Jul/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 27 minutes
                  3h 27m