Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58317

Failed to prefetch template JS Error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.5, 3.2, 3.3
    • Fix Version/s: 3.1.6, 3.2.3
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Apply the testing commit (patch file attached to this issue). 

      Enable debugging, disable cachejs.

      Visit test.php - verify there are not error popups after 10 seconds.

      Show
      Apply the testing commit (patch file attached to this issue).  Enable debugging, disable cachejs. Visit test.php - verify there are not error popups after 10 seconds.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58317-master

      Description

      It is possible to trigger a "failed to pre-fetch template" JS error with a particular nesting of templates. 

      This is due to not waiting for all promises to complete before rendering a template.

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Ryan Wyllie
              Integrator:
              Dan Poltawski
              Tester:
              Jake Dallimore
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/May/17