Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58358

core_media_manager constructor page parameter should be optional

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.2
    • Fix Version/s: None
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Disable filter_mediaplugins
      2. Make sure video.js is your topmost media plugin
      3. Create a file resource and upload a video to it
      4. Ensure video.js works (should see the rectangular play button at first with no video controls - don't just assume any video player means it's working as it might be HTML5)
      5. Enable filter_mediaplugins
      6. Enable "Convert URLs into links and images" filter
      7. Add a link to a video file
      8. Ensure it works
      Show
      Disable filter_mediaplugins Make sure video.js is your topmost media plugin Create a file resource and upload a video to it Ensure video.js works (should see the rectangular play button at first with no video controls - don't just assume any video player means it's working as it might be HTML5) Enable filter_mediaplugins Enable "Convert URLs into links and images" filter Add a link to a video file Ensure it works
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58358-master

      Description

      make $page optional (since we change the function signature of a protected method, it should be optional)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              johno John Okely
              Reporter:
              johno John Okely
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Dan Poltawski
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: