Loading...

XML

Word

Printable

Affected Branches:
MOODLE_33_STABLE
Fixed Branches:
MOODLE_33_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Main Branch:
wip-~~MDL-58364~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/216ea39be7...wip-MDL-58364-master
Testing Instructions:
Hide

Create course and several activities

Hide some sections

Move activities around and make sure they are moved and visibility is changed properly (for example when activitiy is dragged into hidden section it becomes hidden)

Inspect network tab and make sure each request to service.php is successful (the "Response" should not show any errors returned)
Show
Create course and several activities Hide some sections Move activities around and make sure they are moved and visibility is changed properly (for example when activitiy is dragged into hidden section it becomes hidden) Inspect network tab and make sure each request to service.php is successful (the "Response" should not show any errors returned)

regression from ~~MDL-4782~~
when activity is dragged to another section, there are errors in the network tab:

"* line 333 of /lib/externallib.php: invalid_parameter_exception thrown

* line ? of unknownfile: call to external_api::validate_parameters()

* line 224 of /lib/externallib.php: call to call_user_func()

* line 59 of /lib/ajax/service.php: call to external_api::call_external_function()"

is a regression caused by

MDL-4782 allow resources/activities to be hidden but available/active