[MDL-58452] Do not show popup if message count could not be retrieved - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Insert an exception in core_message::get_unread_conversations_count()

Login as user and open any page

Make sure there are no popups but there is an error in the console

Remove exception

Repeat with message_popup_external::get_unread_popup_notification_count
Note:- Certain FF versions are not compatible with Log.error like 50.1 , try chrome before failing.
Show
Insert an exception in core_message::get_unread_conversations_count() Login as user and open any page Make sure there are no popups but there is an error in the console Remove exception Repeat with message_popup_external::get_unread_popup_notification_count Note:- Certain FF versions are not compatible with Log.error like 50.1 , try chrome before failing.
Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Master Branch:
wip-~~MDL-58452~~-master
Pull Master Diff URL:
https://github.com/marinaglancy/moodle/compare/bd99cb9021...wip-MDL-58452-master

If the request to retrieve message/notification count was not successful for some reason, do not show exception popup, just write to log.

This is a partial solution for ~~MDL-58310~~ but the full solution will be not to process AJAX failures at all that happened because of page reload

has a non-specific relationship to

MDL-58310 Error occurs whenever in progress ajax request is cancelled (random "undefined" popup)

has been marked as being related by

MDL-58310 Error occurs whenever in progress ajax request is cancelled (random "undefined" popup)

MDL-60603 Undefined error message popup

Participants:: Ankit Agarwal, Boisaubert Hugo, CiBoT, Damyon Wiese, Jake Dallimore, Jun Pataleta, Marina Glancy

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)