Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58452

Do not show popup if message count could not be retrieved

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.2
    • Fix Version/s: 3.2.3
    • Component/s: JavaScript, Messages
    • Labels:
    • Testing Instructions:
      Hide
      1. Insert an exception in core_message::get_unread_conversations_count()
      2. Login as user and open any page
      3. Make sure there are no popups but there is an error in the console
      4. Remove exception
      5. Repeat with message_popup_external::get_unread_popup_notification_count
        Note:- Certain FF versions are not compatible with Log.error like 50.1 , try chrome before failing.
      Show
      Insert an exception in core_message::get_unread_conversations_count() Login as user and open any page Make sure there are no popups but there is an error in the console Remove exception Repeat with message_popup_external::get_unread_popup_notification_count Note:- Certain FF versions are not compatible with Log.error like 50.1 , try chrome before failing.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      wip-MDL-58452-master

      Description

      If the request to retrieve message/notification count was not successful for some reason, do not show exception popup, just write to log.

      This is a partial solution for MDL-58310 but the full solution will be not to process AJAX failures at all that happened because of page reload

        Attachments

        1. 1.png
          1.png
          66 kB
        2. 2.png
          2.png
          213 kB
        3. timeout.png
          timeout.png
          24 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/May/17