[MDL-58465] Incorrect usage of moodle_exception - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.2
Fix Version/s: 3.1.6, 3.2.3
Component/s: Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Master Branch:
~~MDL-58465~~-master
Pull Master Diff URL:
https://github.com/ankitagarwal/moodle/compare/216ea39be7...MDL-58465-master
Testing Instructions:

Hide

1/ Testing is optional.

2/ Add this line

$course2['shortname'] = "bla";

above the for loop where the patch makes changes.

3/ Run core_course_externallib_testcase and see the exception. Make sure you get a proper fail and exception, not an undefined error.

Show
1/ Testing is optional. 2/ Add this line $course2 [ 'shortname' ] = "bla" ; above the for loop where the patch makes changes. 3/ Run core_course_externallib_testcase and see the exception. Make sure you get a proper fail and exception, not an undefined error.

Sprint:
3.3 sprint 5

Description

While reviewing ~~MDL-58456~~, I found a few other incorrect usage of moodle_exception

Attachments

Activity

People

Assignee:: Ankit Agarwal

Reporter:: Ankit Agarwal

Peer reviewer:: Marcus Green

Integrator:: Dan Poltawski

Tester:: Dan Poltawski

Participants:: Ankit Agarwal, CiBoT, Dan Poltawski, David Monllaó, Jun Pataleta, Marcus Green

Component watchers:

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 03/Apr/17 7:44 PM

Updated:: 19/Apr/17 5:46 AM

Resolved:: 19/Apr/17 5:46 AM

Fix Release Date:: 8/May/17