Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58485

Plugins overview only shows SVG icon if a non-SVG icon by the same name exists

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.2, 3.3
    • Fix Version/s: 3.1.6, 3.2.3
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      1. Visit admin/plugins.php and confirm that mod_forum has an icon (Bonus step: Look at the used image; confirm that it contains SVG XML tags).
      2. Delete or rename the icon mod/forum/pix/icon.png on your filesystem, leaving the SVG in place.
      3. Visit admin/plugins.php again; confirm that mod_forum still has an icon.

      Show
      1. Visit admin/plugins.php and confirm that mod_forum  has an icon (Bonus step: Look at the used image; confirm that it contains SVG XML tags). 2. Delete or rename the icon mod/forum/pix/icon.png on your filesystem, leaving the SVG in place. 3. Visit admin/plugins.php again; confirm that mod_forum  still has an icon.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull Master Branch:
      mdl-58485

      Description

      admin/plugins.php illustrates each plugin with its own icon. If an SVG icon is present, the SVG icon is preferred over PNG or other pixel formats.

      However, if the plugin only offers an SVG icon, no icon is displayed at all.

      Steps to reproduce:
      1. Visit admin/plugins.php and confirm that mod_forum has an icon (Bonus step: Look at the used image; confirm that it contains SVG XML tags).
      2. Delete or rename the icon mod/forum/pix/icon.png on your filesystem, leaving the SVG in place.
      3. Visit admin/plugins.php again; confirm that only a spacer is shown instead of the mod_forum icon (empty image with icon pluginicon noicon CSS classes.

      By the way, the activity module overview admin/modules.php respects the SVG icon as a standalone

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jan.dagefoerde Jan Dageförde
              Reporter:
              jan.dagefoerde Jan Dageförde
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              David Monllaó
              Tester:
              David Mudrák (@mudrd8mz)
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              3 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/May/17