Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58494

Feedback is always present on dashboard even after it was submitted or completed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 3.3
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide

      Test setup

      1. Create a course
      2. Create two students and enrol them in the course

      Test submitted feedback, no multiple

      1. Create a feedback activity
        • make sure it is set to not allow multiple attempts
        • set either an available to or available from date
      2. Add a question to the feedback activity
      3. Log in as the student and view your dashboard
      4. Confirm that the feedback event is there
      5. Click the link to provide feedback and submit it
      6. View the dashboard and confirm that the feedback event is no longer visible
      7. Log in as the teacher / admin
      8. View the feedback provided and delete the entry from the student
      9. Log back in as the student
      10. View your dashboard and confirm the feedback event is visible again

      Test submitted feedback, allow multiple

      1. Create a feedback activity
        • make sure it is set to allow multiple attempts
        • set either an available to or available from date
      2. Add a question to the feedback activity
      3. Log in as the student and view your dashboard
      4. Confirm that the feedback event is there
      5. Click the link to provide feedback and submit it
      6. View the dashboard and confirm that the feedback event is no longer visible

      Test no submit permission

      1. Create a feedback activity and make sure you set either the available to or from values
      2. Add a question to the feedback
      3. Create a new role based on the student archetype but set the mod/feedback:complete capability to prevent in this new role
      4. Assign one of the two students this new role in the course
      5. Log in as the student without that role and confirm that the feedback event is shown on their dashboard
      6. Log in as the student with that role and confirm that the feedback event is not shown on their dashboard
      7. Confirm that it is also not shown on the calendar for that student
      Show
      Test setup Create a course Create two students and enrol them in the course Test submitted feedback, no multiple Create a feedback activity make sure it is set to not allow multiple attempts set either an available to or available from date Add a question to the feedback activity Log in as the student and view your dashboard Confirm that the feedback event is there Click the link to provide feedback and submit it View the dashboard and confirm that the feedback event is no longer visible Log in as the teacher / admin View the feedback provided and delete the entry from the student Log back in as the student View your dashboard and confirm the feedback event is visible again Test submitted feedback, allow multiple Create a feedback activity make sure it is set to allow multiple attempts set either an available to or available from date Add a question to the feedback activity Log in as the student and view your dashboard Confirm that the feedback event is there Click the link to provide feedback and submit it View the dashboard and confirm that the feedback event is no longer visible Test no submit permission Create a feedback activity and make sure you set either the available to or from values Add a question to the feedback Create a new role based on the student archetype but set the mod/feedback:complete capability to prevent in this new role Assign one of the two students this new role in the course Log in as the student without that role and confirm that the feedback event is shown on their dashboard Log in as the student with that role and confirm that the feedback event is not shown on their dashboard Confirm that it is also not shown on the calendar for that student
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-58494-master

      Description

      1. Completed feedbacks do not disappear from the timeline (for example when activity completion set to "manual" or "require view")

      2. I see the link "Answer the questions" even after I answered the questions and feedback does not allow multiple attempts. Should I see it on the dashboard at all?

      3. I see the text "Answer the questions" when feedback is not open yet without a link - this is confusing

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ryanwyllie Ryan Wyllie
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Marina Glancy
              Integrator:
              Andrew Nicols
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/May/17