Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58512

The online users block pop-up for messaging does not translate the string 'changesmadereallygoaway'

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a course.
      2. Enrol a student in this course.
      3. Add the online users block.
      4. Log in as an admin on one browser and visit the course.
      5. In another browser log in as a student and visit the course.
      6. On the browser as the admin refresh the page (to update the online users block).
      7. Click on the message icon next to the student.
      8. In the pop-up add some text.
      9. Click on the 'X' in the corner.
      10. Confirm you get a message with a valid string.
      Show
      Create a course. Enrol a student in this course. Add the online users block. Log in as an admin on one browser and visit the course. In another browser log in as a student and visit the course. On the browser as the admin refresh the page (to update the online users block). Click on the message icon next to the student. In the pop-up add some text. Click on the 'X' in the corner. Confirm you get a message with a valid string.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:

      Description

      In Moodle 3.1 (likely 2.9 to 3.1, but have not tested fully), on the Online Users block, click the chat bubble icon next to a person's name to message them.

      It pops up an overlay message box on the page where you can type in a message to that person. (https://tracker.moodle.org/browse/MDL-48933)

      If you type in part of a message, then click the x on that overlay box it pops up a confirmation message, I believe moodle-core-notification-confirm with the message string for changesmadereallygoaway. The problem is rather than displaying the text of the string "You have made changes. Are you sure you want to navigate away and lose your changes?", it displays the literal text "[[changesmadereallygoaway,moodle]]"

       

        Attachments

          Activity

            People

            Assignee:
            mgancarzdsi Mathew Gancarz
            Reporter:
            mgancarzdsi Mathew Gancarz
            Peer reviewer:
            Mark Nelson
            Integrator:
            David Monllaó
            Tester:
            John Okely
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/May/17