Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58515

Annotated PDF comments aren't handling tab focus correctly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 3.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      • Create an assignment in a course with at least one student.
      • As a student, submit to the assignment.
      • As a teacher, grade the submission and annotate a few comments.
      • Tab around the grading page and verify that:
        • all comments can be focused (in the correct order),
        • each comment's menu can be focused (after the comment itself),
        • all elements display a focus outline when focused,
        • all of the above also works as expected when reverse (Shift) tabbing.
      • Test with both Clean and Boost themes, and in all supported browsers.
      Show
      Create an assignment in a course with at least one student. As a student, submit to the assignment. As a teacher, grade the submission and annotate a few comments. Tab around the grading page and verify that: all comments can be focused (in the correct order), each comment's menu can be focused (after the comment itself), all elements display a focus outline when focused, all of the above also works as expected when reverse (Shift) tabbing. Test with both Clean and Boost themes, and in all supported browsers.
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58515-master

      Description

      The changes made in MDL-55459 have changed the behaviour of the annotated PDF comments in the tab order.

      On Chrome the comments can receive focus however they don't show the focus outline. We need all elements to show the focus outline when they have focus for accessibility reasons.

      On Safari the comments aren't focusable at all using the tab key.

      I believe both issues are caused by having elements with tabindex="0" being nested within elements that have tabindex="-1". This can cause weird behaviour for browsers.

      The focus handling needs to be cleaned up a bit.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/May/17