Loading...

XML

Word

Printable

Affected Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
Pull from Repository:
https://github.com/melanietreitinger/moodle
Pull 4.1 Branch:
~~MDL-58517~~-401-trim-is_domain_in_allowed_list
Pull 4.1 Diff URL:
https://github.com/melanietreitinger/moodle/commit/04f5a239590cbcdf119af59a1e9ce048eac2b525.diff
Pull Main Branch:
~~MDL-58517~~-master-trim-is_domain_in_allowed_list
Pull Main Diff URL:
https://github.com/melanietreitinger/moodle/commit/324c04764a3b361c1265378e32fe0facac1bc313.diff
Workaround:

Hide

Enter all domains in proxybypass without space after the comma.

Show
Enter all domains in proxybypass without space after the comma.

From testing of ~~MDL-58220~~

iwontmatch.com,gmail.com - works
iwontmatch.com, gmail.com - fails

Each part should be trimmed before comparison.

Discovered while testing

MDL-58220 Implement Better office integrations project

has a non-specific relationship to

MDL-58038 Email: Allowed domain name check fails for all domains except last one (PHP_EOL mismatch)

will be (partly) resolved by

MDL-79121 prevent admins to define an invalid proxybypass value

Participants:: CiBoT, Damyon Wiese, Matteo Scaramuccia, Matt Porritt, Melanie Treitinger, Paul Holden