Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58543

oauth2 upgrade steps skipped on master

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      NOTE: Recommended to enable develeoper debugging and keep and eye on them (logs and/or on display).

      A) People who installs weeklies normally was not affected:

      • Install Moodle bf919dd (31 March weekly). As far as you'll need to repeat this a number of times, it's recommended to save a copy of this installation.
        • VERIFY:
          • No errors happen on upgrade.
          • The 4 tables do not exist (oauth2_issuer, oauth2_endpoint, oauth2_system_account, oauth2_user_field_mapping).
      • Upgrade to Moodle bd99cb9 (7 April weekly).
        • VERIFY:
          • No errors happen on upgrade.
          • The 4 tables are created (oauth2_*).
          • Verify that "OAuth 2 Services" in admin shows some buttons ("create xxx service ...") and no error.
      • Upgrade to HEAD of integration / master (this patch applied).
        • VERIFY:
          • No errors happen on upgrade.
          • The 4 tables are created (oauth2_*).
          • Verify that "OAuth 2 Services" in admin shows some buttons ("create xxx service ...") and no error.

      With the last 3 points working we verify that the new steps do not add any problem to a working site.

      B) People who installed an "incorrect" version of integration.git and was facing this bug:

      • Install Moodle bf919dd (31 March weekly). Or restore it from backup created in prev. section. Nothing to verify, was done in A).
      • Upgrade to Moodle 1e3aa70 (one of the bumps that caused the problem).
        • VERIFY:
          • No errors happen on upgrade.
          • The 4 tables do not exist (oauth2_*).
      • Upgrade to Moodle bd99cb9 (7 April weekly).
        • VERIFY:
          • No errors happen on upgrade.
          • The 4 tables do not exist (oauth2_*).
          • Verify that "OAuth 2 Services" in admin ends with error because the 4 tables are expected to exist and are missing.
      • Upgrade to HEAD of integration / master (this patch applied).
        • VERIFY:
          • No errors happen on upgrade.
          • The 4 tables are created (oauth2_*).
          • Verify that "OAuth 2 Services" in admin shows some buttons ("create xxx service ...") and NO error.

      With the 3 last points working, the patch fixed the problem for sites that were missing the tables.

      That's all, ciao

      Show
      NOTE: Recommended to enable develeoper debugging and keep and eye on them (logs and/or on display). A) People who installs weeklies normally was not affected: Install Moodle bf919dd (31 March weekly). As far as you'll need to repeat this a number of times, it's recommended to save a copy of this installation. VERIFY: No errors happen on upgrade. The 4 tables do not exist (oauth2_issuer, oauth2_endpoint, oauth2_system_account, oauth2_user_field_mapping). Upgrade to Moodle bd99cb9 (7 April weekly). VERIFY: No errors happen on upgrade. The 4 tables are created (oauth2_*). Verify that "OAuth 2 Services" in admin shows some buttons ("create xxx service ...") and no error. Upgrade to HEAD of integration / master (this patch applied). VERIFY: No errors happen on upgrade. The 4 tables are created (oauth2_*). Verify that "OAuth 2 Services" in admin shows some buttons ("create xxx service ...") and no error. With the last 3 points working we verify that the new steps do not add any problem to a working site. B) People who installed an "incorrect" version of integration.git and was facing this bug: Install Moodle bf919dd (31 March weekly). Or restore it from backup created in prev. section. Nothing to verify, was done in A). Upgrade to Moodle 1e3aa70 (one of the bumps that caused the problem). VERIFY: No errors happen on upgrade. The 4 tables do not exist (oauth2_*). Upgrade to Moodle bd99cb9 (7 April weekly). VERIFY: No errors happen on upgrade. The 4 tables do not exist (oauth2_*). Verify that "OAuth 2 Services" in admin ends with error because the 4 tables are expected to exist and are missing. Upgrade to HEAD of integration / master (this patch applied). VERIFY: No errors happen on upgrade. The 4 tables are created (oauth2_*). Verify that "OAuth 2 Services" in admin shows some buttons ("create xxx service ...") and NO error. With the 3 last points working, the patch fixed the problem for sites that were missing the tables. That's all, ciao
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      It looks like I messed up the oauth2 upgrade merge:

      1) Merged onto 1e3aa70ff0

      commit 3ca68f24f7ee4c39d01e41cd3ab051bd9920501d
      Merge: 1e3aa70ff0 aa89bf2e6c
      Author: Dan Poltawski <dan@moodle.com>
      Date:   Mon Apr 3 12:41:56 2017 +0100
       
          Merge branch 'MDL-58220-master' of git://github.com/damyon/moodle
      
      

      2) 1e3aa70ff0 is 2017040300.00

      3) The upgrade steps are starting at 2017033100.01..

      if ($oldversion < 2017033100.01) {}}
      

      So, the upgrade step is broken for any people testing from master versions. Not sure how this was not detected during testing. It's breaking the QA site, as spotted by mary

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/May/17