Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58548

Upgrade HTMLPurifier to 4.9.3 for Moodle 3.4 release

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 3.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Stolen from -MDL-52651-

      1. Create a forum.
      2. In a discussion, add in HTML links with and without the target attribute.
        • Note: You will need to only use the value _blank for target as other values are filtered out.
      3. Save.
      4. View the discussion and verify that any links that have the target attribute will have rel=noreferrer noopener attribute added. Make sure the when opening a target="_blank" link that the original page is not redirected.
      5. Try the same sort of thing in other text areas and see if any don't add the attribute.

      Example:

      This:
      <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank">Test my link</a>
       
      Becomes:
      <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank" rel="noreferrer noopener" id="yui_3_15_0_3_1425447153706_281">Test my link</a>

      • Run all unit tests and check that failures don't relate to this issue.
      Show
      Stolen from - MDL-52651 - Create a forum. In a discussion, add in HTML links with and without the target attribute. Note: You will need to only use the value _blank for target as other values are filtered out. Save. View the discussion and verify that any links that have the target attribute will have rel=noreferrer noopener attribute added. Make sure the when opening a target="_blank" link that the original page is not redirected. Try the same sort of thing in other text areas and see if any don't add the attribute. Example: This: <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank">Test my link</a>   Becomes: <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank" rel="noreferrer noopener" id="yui_3_15_0_3_1425447153706_281">Test my link</a> Run all unit tests and check that failures don't relate to this issue.
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-58548-master
    • Sprint:
      3.4 Sprint 5

      Description

      Update HTMLPurifier to 4.9.3

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17