Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58567

Upgrade: Show upgrade times

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Upgrade test
      GUI debugging OFF
      1. Switch to MOODLE_32_STABLE branch
      2. Install Moodle 3.2 via GUI (or if using MDK, "mdk install").
      3. Switch branch to master.
      4. Upgrade the site via GUI.
        • Confirm that you see the time duration of each upgrade success notification for each component that has been upgraded. (e.g. "Success (0.61 seconds)")
      GUI debugging ON
      1. Drop the database and create a new one. (Or if using MDK, just do "mdk uninstall -y")
      2. Switch again to MOODLE_32_STABLE branch.
      3. Install Moodle 3.2 via GUI and turn debugging ON. (Or if using MDK, just do "mdk install -r mindev")
      4. Switch branch to master.
      5. Upgrade the site via GUI.
        • Confirm that you see the time duration of each upgrade step notification for each component that has been upgraded. (e.g. "2017051500: Success (0.01 seconds)")
        • Confirm that you see the time duration of each upgrade success notification for each component that has been upgraded. (e.g. "Success (0.61 seconds)")
      CLI debugging OFF
      1. Drop the database and create a new one. (Or if using MDK, just do "mdk uninstall -y")
      2. Switch again to MOODLE_32_STABLE branch.
      3. Install Moodle 3.2 via GUI or CLI. (Or if using MDK, just do "mdk install")
      4. Switch branch to master.
      5. Upgrade the site via CLI.

        php admin/cli/upgrade.php --non-interactive --allow-unstable
        

        • Confirm that you see the time duration for each component that has been upgraded.
          Example:

          -->enrol_lti
          ++ Success (0.14 seconds) ++
          

      CLI debugging ON
      1. Drop the database and create a new one. (Or if using MDK, just do "mdk uninstall -y")
      2. Switch again to MOODLE_32_STABLE branch.
      3. Install Moodle 3.2 via GUI and turn debugging ON. (Or if using MDK, just do "mdk install -r mindev")
      4. Switch branch to master.
      5. Upgrade the site via CLI.

        php admin/cli/upgrade.php --non-interactive --allow-unstable
        

        • Confirm that you see the upgrade step and its corresponding time duration for each component that has been upgraded.
        • Confirm that you see the time duration for each component that has been upgraded.
          Example:

          -->enrol_lti
          ++ 2017011300: Success (0.03 seconds) ++
          ++ 2017051500: Success (0.03 seconds) ++
          ++ Success (0.14 seconds) ++
          

      Install test
      1. Do a fresh Moodle install via GUI
        • Confirm that you don't see any time duration information for each component that got installed.
      2. Do a fresh Moodle install via CLI
        • Confirm that you also don't see any time duration information for each component that got installed.
      Show
      Upgrade test GUI debugging OFF Switch to MOODLE_32_STABLE branch Install Moodle 3.2 via GUI (or if using MDK, " mdk install "). Switch branch to master. Upgrade the site via GUI. Confirm that you see the time duration of each upgrade success notification for each component that has been upgraded. (e.g. " Success (0.61 seconds) ") GUI debugging ON Drop the database and create a new one. (Or if using MDK, just do " mdk uninstall -y ") Switch again to MOODLE_32_STABLE branch. Install Moodle 3.2 via GUI and turn debugging ON. (Or if using MDK, just do " mdk install -r mindev ") Switch branch to master. Upgrade the site via GUI. Confirm that you see the time duration of each upgrade step notification for each component that has been upgraded. (e.g. " 2017051500: Success (0.01 seconds) ") Confirm that you see the time duration of each upgrade success notification for each component that has been upgraded. (e.g. " Success (0.61 seconds) ") CLI debugging OFF Drop the database and create a new one. (Or if using MDK, just do " mdk uninstall -y ") Switch again to MOODLE_32_STABLE branch. Install Moodle 3.2 via GUI or CLI. (Or if using MDK, just do " mdk install ") Switch branch to master. Upgrade the site via CLI. php admin/cli/upgrade.php --non-interactive --allow-unstable Confirm that you see the time duration for each component that has been upgraded. Example: -->enrol_lti ++ Success (0.14 seconds) ++ CLI debugging ON Drop the database and create a new one. (Or if using MDK, just do " mdk uninstall -y ") Switch again to MOODLE_32_STABLE branch. Install Moodle 3.2 via GUI and turn debugging ON. (Or if using MDK, just do " mdk install -r mindev ") Switch branch to master. Upgrade the site via CLI. php admin/cli/upgrade.php --non-interactive --allow-unstable Confirm that you see the upgrade step and its corresponding time duration for each component that has been upgraded. Confirm that you see the time duration for each component that has been upgraded. Example: -->enrol_lti ++ 2017011300: Success (0.03 seconds) ++ ++ 2017051500: Success (0.03 seconds) ++ ++ Success (0.14 seconds) ++ Install test Do a fresh Moodle install via GUI Confirm that you don't see any time duration information for each component that got installed. Do a fresh Moodle install via CLI Confirm that you also don't see any time duration information for each component that got installed.
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-58567-master-v2

      Description

      In order to track down problems and as a step to help improve upgrade performance, it would be useful if the Moodle upgrade procedure showed times alongside each step. I propose:

      1. In the standard upgrade, display 'Success (0.31 seconds)' in each place where we currently display 'Success'.
      2. If developer debugging is turned on, also display a list of each plugin savepoint (version number) along with the time to that step, e.g. '2017041200: Success (0.31 seconds)'

      This display should work in both the web upgrade and CLI upgrade modes.

       

      Note: This was raised in a discussion at the UK 2017 Moot developer workshop.

        Attachments

        1. cli-screen.png
          cli-screen.png
          15 kB
        2. outputcli_debug.png
          outputcli_debug.png
          105 kB
        3. outputcli_nodebug.png
          outputcli_nodebug.png
          61 kB
        4. outputweb_nodebug.png
          outputweb_nodebug.png
          34 kB
        5. outputweb.png
          outputweb.png
          41 kB
        6. outputweb1.png
          outputweb1.png
          51 kB
        7. web-screen.png
          web-screen.png
          29 kB

          Activity

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17