Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58582

PHPDocs of resolve_image_location are partially inaccurate


    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.1.6, 3.2.3
    • 3.1.5, 3.2.2, 3.3
    • Themes

      During testing of MDL-58485, mudrd8mz correctly pointed out that the phpdocs of the \theme_config::resolve_image_location function (particularly, for the parameter $svg are inaccurate:

      @param bool $svg If set to true SVG images will also be looked for.

      However, implementation of that function explicitly handles the case that $svg is null, which results in a fallback to browser support of SVGs. Therefore, docs should be updated to

      @param bool|null $svg Should SVG images be also looked for, null for auto-detection of browser support.

      ... I'll prepare a patch.

            jan.dagefoerde Jan Dageförde
            jan.dagefoerde Jan Dageförde
            Ankit Agarwal Ankit Agarwal
            Andrew Lyons Andrew Lyons
            Andrew Lyons Andrew Lyons
            0 Vote for this issue
            3 Start watching this issue


                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.