Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 3.1.6, 3.2.3
Affects Version/s: 3.1.5, 3.2.2
Component/s: Backup, Database SQL/XMLDB, Performance
Labels:
- ci
- release_notes

Affected Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Pull from Repository:
git://github.com/merrill-oakland/moodle.git
Pull Main Branch:
~~MDL-58593~~-master
Pull Main Diff URL:
https://github.com/merrill-oakland/moodle/compare/0714bcb2a2...MDL-58593-master
Testing Instructions:
- Make sure backup/restore work as you would expect
- Run an automated backup that covers at least a few courses
- Run unit tests

Description

We (and others) have noticed that when using scripts that create backups (so many are made during one session), each trip through the process the backup gets slower and slower.

I've tracked it down to sql_generator->getNameForObject(), it uses a tracking array to keep track of index names it has already issued, in an inefficient way.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

capture-for-jira-screenshot-20170418-133838-069.png
96 kB
19/Apr/17 12:08 AM
Selection_353.png
95 kB
19/Apr/17 12:11 AM

Issue Links

Testing discovered

MDL-58625 Persistent related debugging during restore

Closed

Activity

People

Assignee:: Eric Merrill

Reporter:: Eric Merrill

Peer reviewer:: Eloy Lafuente (stronk7)

Integrator:: Dan Poltawski

Tester:: Ankit Agarwal

Participants:: Ankit Agarwal, Charles Fulton, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Eric Merrill

Votes:: 9 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 14/Apr/17 4:58 AM

Updated:: 28/Jul/18 1:16 AM

Resolved:: 19/Apr/17 5:45 AM

Fix Release Date:: 8/May/17