Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58613

Random allocation with Remove current allocations selected results in debug messages

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.5, 3.2.2, 3.3
    • Fix Version/s: 3.1.6, 3.2.3
    • Component/s: Workshop
    • Labels:
    • Testing Instructions:
      Hide
      1. Check that the developer debugging is on and debug messages are displayed.
      2. As a teacher, prepare a new Workshop and switch it to the submission phase
      3. Let some students submit their work (two or three should be enough).
      4. As a teacher, go to the Random allocation page and allocate submissions randomly.
      5. Repeat the random allocation with the "Remove current allocations" option checked.
      6. TEST: Make sure you can see the allocation log info "Deallocating <number> assessment(s)" (displayed in blue by default, see attached screenshot-1.png).
      7. TEST: Make sure the reported debugging message is not displayed on this page.

      I believe it is enough to have this tested on one branch.

      Show
      Check that the developer debugging is on and debug messages are displayed. As a teacher, prepare a new Workshop and switch it to the submission phase Let some students submit their work (two or three should be enough). As a teacher, go to the Random allocation page and allocate submissions randomly. Repeat the random allocation with the "Remove current allocations" option checked. TEST: Make sure you can see the allocation log info "Deallocating <number> assessment(s)" (displayed in blue by default, see attached screenshot-1.png). TEST: Make sure the reported debugging message is not displayed on this page. I believe it is enough to have this tested on one branch.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58613-master-workshopfullname
    • Pull Master Diff URL:

      Description

      The first time using Random Allocation, works fine. If you run it again, with Remove current allocations ticked, you get multiple copies of this debug message:

      You need to update your sql to include additional name fields in the user object.

          line 3379 of /lib/moodlelib.php: call to debugging()
          line 173 of /mod/workshop/allocation/random/lib.php: call to fullname()
          line 72 of /mod/workshop/allocation/random/lib.php: call to workshop_random_allocator->execute()
          line 52 of /mod/workshop/allocation.php: call to workshop_random_allocator->init()

        Attachments

          Issue Links

          Discovered while testing

          Functional Test - A test of a single Moodle feature MDLQA-10462 CLONE - A teacher can allocate workshop submissions randomly or manually

          • Critical - Crashes server, loss of data, severe memory leak
          • Passed

            Activity

              People

              Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              alrachels AL Rachels
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Jake Dallimore
              Tester:
              cameron1729
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/May/17