Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58646

Time to reset caches (compile Boost) recently became 3x slower

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Use boost theme
      2. Purge caches
      3. VERIFY: css is recreated and moodle is styled
      4. Change a boost setting such as brand colour
      5. VERIFY: css is changed and the look of site has changed
      6. VERIFY Using curl or the web inspector, examine the time to compile the scss before and after the patch and that with the patch, peformance is dramatically improved.

      For example, using curl, you can use styles_debug to do this:

      curl -s -w "\nConnect time: %{time_connect} Time to first byte: %{time_starttransfer} Total time: %{time_total} \n" -o /dev/null 'http://[YOUMOODLE]/theme/styles_debug.php?theme=boost&type=scss'

      Ensure that css is flipped when in an RTL language

      Show
      Use boost theme Purge caches VERIFY: css is recreated and moodle is styled Change a boost setting such as brand colour VERIFY: css is changed and the look of site has changed VERIFY Using curl or the web inspector, examine the time to compile the scss before and after the patch and that with the patch, peformance is dramatically improved. For example, using curl, you can use styles_debug to do this: curl -s -w "\nConnect time: %{time_connect} Time to first byte: %{time_starttransfer} Total time: %{time_total} \n" -o /dev/null 'http://[YOUMOODLE]/theme/styles_debug.php?theme=boost&type=scss' Ensure that css is flipped when in an RTL language
    • Workaround:
      Hide
      1. Edit /theme/boost/scss/moodle.scss
      2. Move the following lines at the END of the file 

        // Import font awesome.
        		 
        @import "fontawesome/moodle-path";
        		 
        @import "fontawesome/font-awesome";

      3. Save and done.

      On my system, the compile goes from taking about 16s, to 7.5s.

      Show
      Edit /theme/boost/scss/moodle.scss Move the following lines at the END of the file // Import font awesome. @import "fontawesome/moodle-path"; @import "fontawesome/font-awesome"; Save and done. On my system, the compile goes from taking about 16s, to 7.5s.
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58646-master
    • Pull Master Diff URL:

      Description

      Based on some comments from David Mudrák (@mudrd8mz) in the dev chat, that I also had recently experienced... I did conduct this quick test using a 1-step feature:

      Feature: Simple feature
      		 
       
        @javascript
      		 
        Scenario: Simple feature
      		 
          Then I should see "test"

      running it against 32_STABLE, some weeks old master and current master... and it seems obvious that something has changed recently, making it really slower (30 seconds vs > 90 seconds in same installation:

      https://pastebin.com/K7wVci9f

      Worth checking what's going there. Specially in case if affects normal execution too.

      Ciao

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57387 When scss fails to compile, we should fall back to something good

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45771 Improve SCSS/JS caching for Behat

          • Minor - Minor loss of function where workaround is possible
          • Open
          Testing discovered

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDL-59122 Improvements to dynamic scss compilation/caching etc

          • Critical - Crashes server, loss of data, severe memory leak
          • Open

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-59154 CSS Generation never locks correctly

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              David Monllaó David Monllaó
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Ryan Wyllie Ryan Wyllie
              Participants:
              Component watchers:
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              24 Vote for this issue
              Watchers:
              39 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17