Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58658

Static acceleration not working on empty arrays

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.5, 3.2.2, 3.3
    • Fix Version/s: 3.2.4, 3.3.1
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide

      Difficulty: developer.. (we can delegate to unit test, but you might find this an interesting learning experience to write a muc cache)

      • Create a MUC cache, with static acceleration
      • Store "world" in the key "hello"
      • Store an empty array ([]) in the key "test"
      • Create a page that will get both keys, twice
      • Load the page with all the debug options turned on (perfinfo)
      • Check that static acceleration only returned one key
      • Apply patch
      • Load page again, check static acceleration returned both keys
      Show
      Difficulty: developer.. (we can delegate to unit test, but you might find this an interesting learning experience to write a muc cache) Create a MUC cache, with static acceleration Store "world" in the key "hello" Store an empty array ([]) in the key "test" Create a page that will get both keys, twice Load the page with all the debug options turned on (perfinfo) Check that static acceleration only returned one key Apply patch Load page again, check static acceleration returned both keys
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      If you store an empty array in MUC, it is never retrieved via static acceleration. Yet, we expect MUC to store and return empty arrays fairly often.

        Attachments

          Activity

            People

            Assignee:
            skylarkelty Skylar Kelty
            Reporter:
            skylarkelty Skylar Kelty
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Dan Poltawski
            Tester:
            Adrian Greeve
            Participants:
            Component watchers:
            Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Jul/17