[MDL-58666] Avoid extra db queries when building course cache - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_33_STABLE
Fixed Branches:
MOODLE_33_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Main Branch:
wip-~~MDL-58666~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/4b358b4f39...wip-MDL-58666-master
Testing Instructions:
Hide

Create a course with one instance of each of these activities: choice, database, feedback, forum, glossary, lesson, quiz, scorm, survey and enable automatic completion for all of them either individually or using awesome new bulk edit completion form

Purge all caches and view course page again - there should be no errors and all activities names should be displayed correctly
Show
Create a course with one instance of each of these activities: choice, database, feedback, forum, glossary, lesson, quiz, scorm, survey and enable automatic completion for all of them either individually or using awesome new bulk edit completion form Purge all caches and view course page again - there should be no errors and all activities names should be displayed correctly

I noticed that in callbacks introduced in ~~MDL-58190~~ we do not add name to the cached object, this results in extra db query in this line:
https://github.com/moodle/moodle/blob/master/course/lib.php#L511

is a regression caused by

MDL-58190 Create an api to fetch active completion rule descriptions for activities

Participants:: CiBoT, David Monllaó, Juan Leyva, Marcus Green, Marina Glancy