Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58680

Apply filtering to database templates

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Create a database activity with one of each type of field

      Create a glossary

      Enable Glossary auto-linking filter

      Add a glossary with an entry of glossaryentry

      Edit the database view single template and put the word glossaryentry into it

      Create a database record with the word glossaryentry in a text and textarea field

      The word glossaryentry should be auto linked where it appears in the template (by this patch) and the textarea field (pre-existing) but NOT in the text field (since this patch does not alter the contents of fields.

       

       

      Create a field called glossaryentry

      Enable developer debugging

      View the record

      You should see a warning that there has been a collision between a tag and a filter

      Show
      Create a database activity with one of each type of field Create a glossary Enable Glossary auto-linking filter Add a glossary with an entry of glossaryentry Edit the database view single template and put the word glossaryentry into it Create a database record with the word glossaryentry in a text and textarea field The word glossaryentry should be auto linked where it appears in the template (by this patch) and the textarea field (pre-existing) but NOT in the text field (since this patch does not alter the contents of fields.     Create a field called glossaryentry Enable developer debugging View the record You should see a warning that there has been a collision between a tag and a filter
    • Affected Branches:
      MOODLE_311_STABLE, MOODLE_32_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      None of filters for Moodle (e.g. Jmol) work with the database module (from Moodle 1.8 upwards, including 2+ and 3+ versions). 
      E.g.: if you place multimedia file into database field (with type File), there is no player showed as obvious in HTML page activity, only file name with link. https://tracker.moodle.org/browse/MDL-12770

      Similar issue was reported for different filters (MDL-10851). Reopened as new issue from https://tracker.moodle.org/browse/MDL-12770. This deals with database module function, solving this will be huge improvement in functionality. It is better discuss functionality and reasons for not to work on this than neglect it as old issue.

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-60455 Multilang filter bug with Glossary

          • Major - Major loss of function, incorrect output
          • Open

          Improvement - An enhancement to an existing Moodle feature. MDL-71006 This project identified the problem areas in both the database activity's UI and UX and then developed possible solutions in the form of design documents and project proposals.

          • Major - Major loss of function, incorrect output
          • Open

          Improvement - An enhancement to an existing Moodle feature. MDL-62352 Set default $CFG->forceclean to 1

          • Minor - Minor loss of function where workaround is possible
          • Open
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-66104 Make HTMLPurifier handling of ‹nolink› tags to support them everywhere

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-10851 Multilang filter does not work in the Database Activity

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-66104 Make HTMLPurifier handling of ‹nolink› tags to support them everywhere

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              andrew_dc_hancox Andrew Hancox
              Reporter:
              martin.slavik Martin Slavík
              Peer reviewer:
              Daniel Neis Araujo Daniel Neis Araujo
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              38 Vote for this issue
              Watchers:
              22 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 1 minute
                  5h 1m