Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58699

Prevent start/continue attempt buttons to be shown with JS disabled for "protected" quizzes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.5, 3.2.2, 3.3
    • Fix Version/s: 3.2.6, 3.3.3
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

       Login as a teacher, edit the settings for the quiz and set the browser security to 'Full screen pop-up with some JavaScript security'.
      2. Login as a student and attempt the quiz.
      3. Check that the quiz starts immediately and appears in a full screen popup window that covers all the other windows and has no navigation controls.
      4. Check that you are unable to copy and paste in the popup window.
      5. Disable JavaScript in the web-browser and reload the page. Check that the "Attempt quiz now" button doesn't appear.

       

      Show
       Login as a teacher, edit the settings for the quiz and set the browser security to 'Full screen pop-up with some JavaScript security'. 2. Login as a student and attempt the quiz. 3. Check that the quiz starts immediately and appears in a full screen popup window that covers all the other windows and has no navigation controls. 4. Check that you are unable to copy and paste in the popup window. 5. Disable JavaScript in the web-browser and reload the page. Check that the "Attempt quiz now" button doesn't appear.  
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58699-master
    • Pull Master Diff URL:

      Description

      One of the features of the "Full screen pop-up with some JavaScript security" setting is that, with JS disabled in the browser, the buttons available to start and continue an attempt are not show and, instead a "Javascript must be enabled to continue!" message is shown.

      And that exact feature has been covered by a test always (see point #4 of MDLQA-10502 for Moodle 3.3).

      But it seems that, with the changes performed by MDL-46091 this feature stopped working (since Moodle 3.1) and now it's perfectly possible to start/continue an attempt with JS disabled, so it accepts copy/paste... rendering the "Full screen pop-up with some JavaScript security" setting useless.

      So this issue is about to make that functionality back to work and avoid showing those start/continue buttons to anybody with JS disabled when the setting is enabled.

        Attachments

          Issue Links

          blocks

          Functional Test - A test of a single Moodle feature MDLQA-11097 CLONE - A teacher can set a quiz to display in a full-screen popup

          • Critical - Crashes server, loss of data, severe memory leak
          • Passed
          Discovered while testing

          Functional Test - A test of a single Moodle feature MDLQA-10502 CLONE - A teacher can set a quiz to display in a full-screen popup

          • Critical - Crashes server, loss of data, severe memory leak
          • Passed
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-46091 Rationalise confirmations when you start a quiz

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Sara Arjona (@sarjona)
              Integrator:
              David Monllaó
              Tester:
              Mihail Geshoski
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17