-
Bug
-
Resolution: Fixed
-
Minor
-
3.1.5, 3.2.2, 3.3, 3.4.3, 3.5
-
MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
-
MOODLE_34_STABLE, MOODLE_35_STABLE
-
MDL-58702-master -
Easy
-
Testing steps:
- Login as Admin into a Moodle that has been populated with Users (i.e. use mdk run users)
- Use the backup MBZ file (backup-moodle2-course-13-lessontest-20170425-0831.mbz
) attached to this report - Go to Site Administration > Courses tab > Restore course
- In the Import a backup file page, drag and drop the MBZ file to the File picker and click Restore button
- In the Restore as a new course, click on the Miscellaneous radio button and click Continue
- In the Restore settings, click Next
- In the Course settings, click Next
- In the Backup settings, click Perform restore
- You should see the Restore role mappings options with correct labels showing (like the screenshot below)
- As Admin, go to Site Administration > Users tab > Define roles and edit the Manager, Teacher, or Student roles' shortname (or delete it and recreate it)
- Test the backup restoration from Step 2 again to ensure the labels are displayed properly in Step 9.
- For renamed / recreated roles the label should be displayed still
- For deleted roles where there are no equivalent alternatives then the label will display "Role mapping undefined for: '{ backup archetype }' archetype".
- e.g. Role mapping undefined for: 'manager' archetype
- e.g. Role mapping undefined for: 'manager' archetype
Testing steps: Login as Admin into a Moodle that has been populated with Users (i.e. use mdk run users) Use the backup MBZ file ( backup-moodle2-course-13-lessontest-20170425-0831.mbz ) attached to this report Go to Site Administration > Courses tab > Restore course In the Import a backup file page, drag and drop the MBZ file to the File picker and click Restore button In the Restore as a new course , click on the Miscellaneous radio button and click Continue In the Restore settings , click Next In the Course settings , click Next In the Backup settings , click Perform restore You should see the Restore role mappings options with correct labels showing (like the screenshot below) As Admin, go to Site Administration > Users tab > Define roles and edit the Manager, Teacher, or Student roles' shortname (or delete it and recreate it) Test the backup restoration from Step 2 again to ensure the labels are displayed properly in Step 9. For renamed / recreated roles the label should be displayed still For deleted roles where there are no equivalent alternatives then the label will display "Role mapping undefined for: '{ backup archetype }' archetype". e.g. Role mapping undefined for: 'manager' archetype
Steps to reproduce:
- Restore the attached backup file into 32 with users included
- Get to the point in restore process which asks about role mappings
Expected results:
The form should have a label which indicates what is being mapped
Actual results:
The form label is empty
Additional technical details:
The html generated has empty label tag:
<div class="detail-pair">
|
<label class="detail-pair-label" for="detail-pair-value-1"></label>
|
<div class="detail-pair-value">
|
<select class="select custom-select menumapping1" id="menumapping1" name="mapping1">
|
<option selected="selected" value="1">
|
Manager
|
</option>
|
<option value="3">
|
Teacher
|
</option>
|
<option value="4">
|
Non-editing teacher
|
</option>
|
<option value="5">
|
Student
|
</option>
|
<option value="0">
|
None
|
</option>
|
</select>
|
</div>
|
</div>
|
