Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58754

Competency unit tests failures on mysql server 5.7

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.5, 3.2, 3.3
    • Fix Version/s: 3.1.6, 3.2.3
    • Component/s: Competencies, Unit tests
    • Labels:

      Description

      See https://gist.github.com/danpoltawski/bdcc134e8c55592f7f0c0e409b24e144

      The competency unit tests have consistent failures when testing against mysql server version 5.7. Note that I can't reproduce this when testing against mysql 5.5

      1) core_competency_api_testcase::test_duplicate_framework
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/classes/api.php:3670
      /Users/danp/moodles/im_mysql/moodle/competency/tests/api_test.php:330
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_api_testcase competency/tests/api_test.php
       
      2) core_competency_api_testcase::test_delete_competency
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator/lib.php:205
      /Users/danp/moodles/im_mysql/moodle/competency/tests/api_test.php:3353
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_api_testcase competency/tests/api_test.php
       
      3) core_competency_api_testcase::test_delete_framework
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator/lib.php:205
      /Users/danp/moodles/im_mysql/moodle/competency/tests/api_test.php:3583
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_api_testcase competency/tests/api_test.php
       
      4) core_competency_api_testcase::test_delete_framework_competency_used_in_plan
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator/lib.php:205
      /Users/danp/moodles/im_mysql/moodle/competency/tests/api_test.php:3638
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_api_testcase competency/tests/api_test.php
       
      5) core_competency_api_testcase::test_delete_framework_competency_used_in_usercompetency
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator/lib.php:205
      /Users/danp/moodles/im_mysql/moodle/competency/tests/api_test.php:3694
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_api_testcase competency/tests/api_test.php
       
      6) core_competency_api_testcase::test_delete_framework_competency_used_in_usercompetencyplan
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator/lib.php:205
      /Users/danp/moodles/im_mysql/moodle/competency/tests/api_test.php:3753
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_api_testcase competency/tests/api_test.php
       
      7) core_competency_api_testcase::test_delete_framework_competency_used_in_template
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator/lib.php:205
      /Users/danp/moodles/im_mysql/moodle/competency/tests/api_test.php:3815
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_api_testcase competency/tests/api_test.php
       
      8) core_competency_api_testcase::test_delete_framework_competency_used_in_course
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator/lib.php:205
      /Users/danp/moodles/im_mysql/moodle/competency/tests/api_test.php:3876
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_api_testcase competency/tests/api_test.php
       
      9) core_competency_external_testcase::test_remove_related_competency
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator/lib.php:205
      /Users/danp/moodles/im_mysql/moodle/competency/tests/external_test.php:2330
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_external_testcase competency/tests/external_test.php
       
      10) core_competency_external_testcase::test_search_competencies_including_related
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator/lib.php:205
      /Users/danp/moodles/im_mysql/moodle/competency/tests/external_test.php:2371
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_external_testcase competency/tests/external_test.php
       
      11) core_competency_generator_testcase::test_create_related_competency
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator/lib.php:205
      /Users/danp/moodles/im_mysql/moodle/competency/tests/generator_test.php:85
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_competency_generator_testcase competency/tests/generator_test.php
       
      12) tool_lpimportcsv_import_testcase::test_import_framework
      core\invalid_persistent_exception: error/invalidpersistenterror (relatedcompetencyid: Data submitted is invalid)
      $a contents: Data submitted is invalid
       
      /Users/danp/moodles/im_mysql/moodle/lib/classes/persistent.php:467
      /Users/danp/moodles/im_mysql/moodle/competency/classes/api.php:3670
      /Users/danp/moodles/im_mysql/moodle/admin/tool/lpimportcsv/classes/framework_importer.php:417
      /Users/danp/moodles/im_mysql/moodle/admin/tool/lpimportcsv/classes/framework_importer.php:422
      /Users/danp/moodles/im_mysql/moodle/admin/tool/lpimportcsv/classes/framework_importer.php:484
      /Users/danp/moodles/im_mysql/moodle/admin/tool/lpimportcsv/tests/import_test.php:47
      /Users/danp/moodles/im_mysql/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit tool_lpimportcsv_import_testcase admin/tool/lpimportcsv/tests/import_test.php
       
      ERRORS!
      Tests: 8109, Assertions: 111025, Errors: 12, Skipped: 64.
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/May/17