Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58770

LTI parameters must be plain text

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. As an administrator, uncheck the "Remove HTML tags from all activity names" box on the Site administration > Appearance > HTML settings page.
      2. Create/edit a course giving it a title such as "This contains <em>HTML</em>".
      3. In this course, create an external (LTI) link to https://lti.tools/test/tp.php with any key and secret.  Give it a description of something like "This link has a <strong>bold</strong> description!".
      4. Launch the tool and check the values of the context_title and resource_link_description parameters - they will contain HTML tags.
      5. Update the system with the proposed code changes
      6. Re-launch the link and the HTML tags should no longer appear in the parameter values send by Moodle.
      Show
      As an administrator, uncheck the "Remove HTML tags from all activity names" box on the Site administration > Appearance > HTML settings page. Create/edit a course giving it a title such as "This contains <em>HTML</em>". In this course, create an external (LTI) link to https://lti.tools/test/tp.php with any key and secret.  Give it a description of something like "This link has a <strong>bold</strong> description!". Launch the tool and check the values of the context_title and resource_link_description parameters - they will contain HTML tags. Update the system with the proposed code changes Re-launch the link and the HTML tags should no longer appear in the parameter values send by Moodle.
    • Workaround:
      Hide

      Do not use HTML in any of the affected elements (e.g. course title, resource link description).

      Show
      Do not use HTML in any of the affected elements (e.g. course title, resource link description).
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:

      Description

      The context_label, context_title, resource_link_title, resource_link_description,  tool_consumer_instance_name and  tool_consumer_instance_description parameters for LTI (external) tools are required to be plain text, so any HTML tags must be removed.  These are the only changes which I believe are needed in order for Moodle to gain IMS Certification for LTI 1.0/1.1.

      See also https://www.imsglobal.org/specs/ltiv1p1p1/implementation-guide

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              svickers Stephen Vickers
              Reporter:
              svickers Stephen Vickers
              Peer reviewer:
              John Okely
              Integrator:
              Jake Dallimore
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17