Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58772

Switching anonymous to non-anon feedback doesn't let users post non-anon feedback

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.6, 3.2.3
    • Fix Version/s: 3.1.6, 3.2.3
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide

      1) Create a Feedback activity in anon mode, multiple responses allowed, have a simple short answer question in it or something.
      2) As a student, leave multiple anonymous responses
      3) As a teacher, switch the activity to non-anon mode.
      4) As the original student, leave another response.
      5) The teacher should see 3 responses on the responses tab - the 2 anon ones and the 1 non-anon one
      6) As the student, leave another response
      7) The teacher should still only see 3 responses, and the non-anon one is the one that should be replaced by the response left in step 6.

      Show
      1) Create a Feedback activity in anon mode, multiple responses allowed, have a simple short answer question in it or something. 2) As a student, leave multiple anonymous responses 3) As a teacher, switch the activity to non-anon mode. 4) As the original student, leave another response. 5) The teacher should see 3 responses on the responses tab - the 2 anon ones and the 1 non-anon one 6) As the student, leave another response 7) The teacher should still only see 3 responses, and the non-anon one is the one that should be replaced by the response left in step 6.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull 3.1 Branch:
    • Pull Master Branch:

      Description

      The feedback module lets you alternate between responses being anonymised and not anonymised. When the module is in anonymous mode, its possible for a single user to make multiple responses.

      There is a bug however when switching from an anonymised feedback that already has responses, to no longer being anonymised. If a user that previously left an anon response goes to add a new response, that new response is still anonymous and replaces one of their previous anonymous responses (at random, as the query used to fetch the response has no ORDER clause).

      1) Feedback is in anon format, multiple responses allowed
      2) UserA leaves 2 anonymised feedbacks
      3) Feedback is changed to non-anon state
      4) UserA goes to leave another feedback
      What happens: The 3rd feedback, rather than appearing as non-anonymous feedback, simply overwrites one of the existing two feedbacks and is still anonymous.

      What should happen: The responses page shows the 3rd feedback as non-anon feedback and the existing 2 anon-feedbacks still exist in the anonymous section below. If the user attempts to change their feedback, that 3rd non-anon feedback is the one that gets updated.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/May/17